fix: handle missing JBoss configuration children - #562
Open
efegokdemir wants to merge 1 commit into
Open
efegokdemir wants to merge 1 commit into
efegokdemir wants to merge 1 commit into
Conversation
Signed-off-by: Efe Gökdemir <efe@rexcode.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
initializeJbossConfigurationnow treats omitted optional JBoss configuration elements as absent values instead of dereferencing null children. This addresses #513 without changing the generated configuration for supplied elements.Changes
Testing
mvn -B -ntp -DskipITs -Dspotless.check.skip=true -Dspotless.apply.skip=true test— passed (49 tests).mvn -B -ntp -DskipITs -Dspotless.check.skip=true -Dspotless.apply.skip=true verify— passed.git diff --check— passed.mvn -B -ntp -Prun-its -Dspotless.check.skip=true -Dspotless.apply.skip=true verify— blocked by the local Java 8/Groovy environment: the Invoker tests reportUnsupported class file major version 71; the failure occurs before the scenario assertions.AI assistance was used during analysis and implementation; the patch and test results were reviewed before submission.
Fixes #513