Repository navigation
fix(ui): tokenize composer branch-picker min-height + cover it in the control-height contract - #821
Merged
Merged
Conversation
3 tasks done
… control-height contract The branch-picker carried a bare `min-height: 24px` while the adjacent workspace-picker used `var(--h-control-sm)`. Both resolve to 24px (a visual no-op — CDP-verified on the live model-processing fixture: both pickers render min-height 24px, content height 36px), but the bare literal is exactly the drift the `control-height-converge` contract exists to prevent. The branch-picker was simply missing from its CONTROL_HEIGHT list (the workspace-picker was already covered there). Fix at the owner: swap the bare 24px for the token, and add .maka-composer-branch-picker to the control-height-converge list so the existing contract guards both pickers (no bare px, expected --h-control-sm tier) instead of needing a parallel guard. Found by the #546 Composer combined-state audit. Refs #546
Astro-Han
force-pushed
the
refactor/composer-branch-picker-token
branch
from
July 12, 2026 13:03
59c4463 to
f4de905
Compare
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.maka-composer-branch-pickermin-heightfrom a bare24pxtovar(--h-control-sm), matching the adjacent workspace-picker..maka-composer-branch-pickerto thecontrol-height-convergecontract's CONTROL_HEIGHT list so the existing owner contract guards both pickers.Why
The branch-picker carried a bare
min-height: 24pxwhile the adjacent workspace-picker usedvar(--h-control-sm)(both resolve to 24px). The bare literal is exactly the drift thecontrol-height-convergecontract exists to prevent — the branch-picker was simply missing from its CONTROL_HEIGHT list (the workspace-picker was already covered). Fix at the owner: swap the token and add the missing list entry, instead of a parallel guard. Found by the #546 Composer combined-state audit. Refs #546.Scope
min-height) + one contract list entry. No new contract file, no helper changes, no other surfaces.Verification
npm run -w @maka/desktop test— 2346/2346 pass (thecontrol-height-convergecontract now covers both pickers).npm run -w @maka/desktop typecheck+test:checks(console/a11y/copy) — clean.model-processingfixture (light-990 / dark-990 / light-990-reduced-motion): both pickers rendermin-height: 24px, content height 36px — the swap is a visual no-op. Per the repo's "style/cascade invariant: computed-style or text-contract" guidance, thecontrol-height-convergecontract is the locking layer; CDP computed-style is the substitute evidence.24px→ token resolving to24px); the contract + CDP computed-style are the locking layers.Impact
None — visual no-op; no behavior, API, or migration change.
Reviewer notes
composer-row-picker-size-contract) duplicating helpers fromsidebar-indicator-size-contract; a Codex review flagged that as over-engineered (the owner contract already existed) and proposed merging the two picker CSS rules. The merge broke two existing contracts (control-height-convergeandproject-context-badge) that assert.maka-composer-workspace-picker {as a standalone rule — the repo's established convention (per refactor(ui): converge remaining sidebar row indicator sizes #743) is per-selector contracts guarding drift, not merging rules. Reassessment from first principles: the real root cause was the branch-picker missing from the owner contract's list, so the clean minimal fix is the one-line swap + one-line list entry.Ready for review
Verificationexplains why it is not applicable (visual no-op; substitute evidence above)