Repository navigation
Conversation
The slice still cited a missing Electron AX e2e spec and pip-motion unit test, treated keyboard as globally disabled, and claimed no Desktop producer for physical intervention and screen lock. Refs apache#3522 Generated-by: Cursor Grok 4.6 Co-authored-by: Cursor <cursoragent@cursor.com>
hqhq1025
left a comment
hqhq1025
left a comment
There was a problem hiding this comment.
No substantiated findings in the five-document diff at e135bec. The corrections match the current source: the two removed test paths are absent; the Storybook AX audit/manifest and narrow-viewport behavior are implemented in scripts/storybook-visual-smoke.mjs:25,31,186; Desktop idle-input and screen-lock guards are assembled at desktop-native-capability-assembly.ts:83,100; keyboard dispatch is capability- and observed-focus-bound at packages/computer-use/src/maka-cu-backend.ts:2070,2079,2311. The four report classes match provider-matrix.mjs:26 and report-sanitize.mjs:200.
Validation: all 11 AX audit unit tests pass under Node 24.18.1, and git diff --check passes. This is documentation-only; I did not rerun macOS physical-input, real-provider or Storybook browser acceptance. The revised wording correctly distinguishes wiring/static evidence from those unperformed checks. No code-level blocker found within this scope; this is not an approval or an independent human review.
Automated review notice: This comment was posted by an automated review agent operated by hqhq1025. It is not an independent human review and does not replace one.
|
Thank you for this contribution, and sorry to close it on process grounds rather than on its merits. The PR's generative-tooling disclosure says Grok was used. SpaceXAI recently changed Grok's Acceptable Use Policy to bar using Grok or its output to develop, or assist anyone in developing, products or services that compete with SpaceXAI, directly or indirectly. That is a field-of-use restriction, and under the ASF's draft generative tooling criteria it would likely place Grok in Category X. It is being discussed on legal-discuss now, and until that is settled the project has been asked not to accept Grok-generated contributions. Code merged here ships under the Apache License to everyone, so the restriction matters even though Maka itself is not the concern. This is not a judgement on the change itself. If you would like to continue, please re-create it with a different tool (or by hand) and open a new PR, noting the tool in the disclosure as usual. We will review it normally.
|
…rift (#5867) Re-creation of #4899 without the disclosed Grok-generated content, per the maintainer guidance on that PR. #5172 already landed the bulk of the Computer Use audit on main; two code-anchored corrections from that review remain outstanding: - foundation-contract: the intervention/lock/stop matrix row still said FAIL with no Desktop production event producer, but the idle-input and screen-lock guards are wired via apps/desktop/src/main/desktop-native-capability-assembly.ts and mapped to user_intervened/screen_locked in packages/computer-use/src/maka-cu-backend.ts. The row is PARTIAL now; there is still no attributable macOS event-tap producer. - model-loop-foundation: keyboard actions were listed as disabled and fail closed alongside the coordinate and pixel paths, but press_key is a semantic action and type/key are implemented in maka-cu-backend.run under the 6.4 focus-binding rules. Refs #3522 Refs #4899 Generated-by: GLM-5.3-Flash (ZCode)
3 participants
Summary
Audits all nine Computer use documents against the current implementation. Five documents had confirmed drift; the other four were accurate as written.
Refs #3522
Verification
npm ci— passed during repository setup; the lockfile has not changed.npm run lint— passed.npm run format:check— passed.npm run build— passed for all workspaces.npx knip --workspace apps/desktop— passed.npx knip --workspace packages/ui— passed.npm run typecheck— failed in unchangedapps/desktop/stories/app-shell.stories.tsxbecauserightCollapsedno longer exists onWorkbarLayoutState(lines 2974, 2990–2991, and 3005). All workspaces before the Desktop Storybook typecheck passed; this PR changes Markdown only.Not run: full
npm test, Desktop E2E, or Computer Use real-provider/real-machine harnesses; this is a documentation-only change.AI use
Select exactly one:
Tool(s) and scope:
Cursor (GPT-5.6 Sol and Grok 4.6) audited the documents against the implementation, drafted the corrections, and reviewed the final diff. @daierenao remains the human contributor of record.
Checklist
Does this PR entail a change in behavior?
Made with Cursor