Repository navigation
test: wait for active session in slash command e2e - #2651
Merged
Merged
Conversation
Astro-Han
marked this pull request as ready for review
August 10, 2026 15:12
Contributor
Author
|
All checks are green. This just fixes a race in the E2E setup and doesn’t change product behavior, so I’m merging it as a low-risk test-only change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/sidediscovery from racing the first send's asynchronoussetActiveIdVerification
npx biome check apps/desktop/e2e/slash-command-menu.spec.tsnpm --workspace @maka/desktop run build:with-depsslash-command-menu.spec.ts: 4 passedRoot cause
The test continued as soon as the locally armed turn exposed the Stop button. The first-send path sets the active session only after
sessions.sendresolves, while/sideis cataloged only when an active session exists. The test could therefore open the slash menu before the session-owning transcript was ready and wait forever on an option that was omitted from that menu instance.Checklist
Does this PR entail a change in behavior?