[NO_MERGE] Extension for deleting redundant message fast view data - #2667
Closed
hungphan227 wants to merge 4 commits into
Closed
[NO_MERGE] Extension for deleting redundant message fast view data#2667hungphan227 wants to merge 4 commits into
hungphan227 wants to merge 4 commits into
Conversation
hungphan227
force-pushed
the
Extension-for-deleting-redundant-message-fast-view-data
branch
from
March 6, 2025 10:22
d6e56d0 to
215695c
Compare
chibenwa
reviewed
Mar 6, 2025
chibenwa
reviewed
Mar 6, 2025
hungphan227
force-pushed
the
Extension-for-deleting-redundant-message-fast-view-data
branch
from
March 7, 2025 01:30
215695c to
ce61177
Compare
hungphan227
force-pushed
the
Extension-for-deleting-redundant-message-fast-view-data
branch
from
March 7, 2025 04:05
a75bb6e to
e66ff08
Compare
chibenwa
reviewed
Mar 7, 2025
chibenwa
reviewed
Mar 7, 2025
chibenwa
reviewed
Mar 7, 2025
chibenwa
approved these changes
Mar 7, 2025
chibenwa
left a comment
chibenwa
left a comment
Contributor
There was a problem hiding this comment.
Good to me.
IMO let's not merge this PR.
Please open another PR with "How to run this extension" in upgrade-instructions.md (so pointing to this PR)
hungphan227
changed the title
hungphan227
changed the title
chibenwa
approved these changes
Mar 10, 2025
quantranhong1999
approved these changes
Mar 12, 2025
chibenwa
reviewed
Mar 12, 2025
| .doOnSuccess(any -> LOGGER.info("Total records deleted: {}", totalDeleted.incrementAndGet())), | ||
| MESSAGE_IDS_PER_SECOND) | ||
| .then() | ||
| .thenReturn(totalDeleted.get()) |
Contributor
There was a problem hiding this comment.
.get needs to be wrapped in a mono overwise it is precomputed before the run of the reactive pipeline
curl -XPOST 127.0.0.1:8000/messageFastViewCleanup
{"totalDeletedMessageFastViewItems":"0"}
VS
Message fast view cleanup complete. Total deleted: 13006007
chibenwa
reviewed
Mar 12, 2025
| } | ||
|
|
||
| public Mono<MessageId> getAllMessageIds() { | ||
| return cassandraAsyncExecutor.executeSingleRow(select.bind()) |
Contributor
There was a problem hiding this comment.
This is clearly faulty we need to return all records, obviously, not just one!
Contributor
Author
There was a problem hiding this comment.
I am very sorry. Do not know why I forget to update this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
require pr #2666