[To rel/0.12] support fill by specific value#3621
Conversation
yanhongwangg
force-pushed
the
add_value_fill
branch
from
3ffcd1b to
575a5b4
Compare
HTHou
changed the title
|
How the feature is defined? |
|
BTW, user guide need to be updated.. |
constant |
|
Hi, I think the user guide is necessary for this new feature. |
I'll add it later |
|
please merge the rel/0.12 to make ci happy. |
HTHou
left a comment
HTHou
left a comment
There was a problem hiding this comment.
Submit a PR to master branch?
| public TimeValuePair getFillResult() { | ||
| switch (dataType) { | ||
| case BOOLEAN: | ||
| return new TimeValuePair( |
There was a problem hiding this comment.
We could cache the primitive value in this class to avoid parse each time, like this:
boolean booleanValue;
int intValue；
long longValue;
float floatValue;
double doubleValue;
There was a problem hiding this comment.
In new commit ,The initialization of value is placed in the constructor，configureFill is null , avoid parse each time
avoid parse each time
After merge,i will cherry pick to master |
| public TimeValuePair getFillResult() { | ||
| switch (dataType) { | ||
| case BOOLEAN: | ||
| return new TimeValuePair(queryTime, new TsPrimitiveType.TsBoolean(booleanValue)); |
There was a problem hiding this comment.
could we cache TsPrimitiveType not the primary type?
There was a problem hiding this comment.
Tsprimitivetype can be cached
| } | ||
|
|
||
| @Override | ||
| public void configureFill( |
cache TsPrimitiveType
6 participants
No description provided.