Skip to content

test(web): reproduce overlapping newest-first message pages - #4719

Open
Subham-KRLX wants to merge 1 commit into
apache:masterfrom
Subham-KRLX:test/web-pagination-4717
Open

Subham-KRLX wants to merge 1 commit into
apache:masterfrom
Subham-KRLX:test/web-pagination-4717

Conversation

@Subham-KRLX

Copy link
Copy Markdown
Contributor

Which issue does this PR address?

Relates to #4717

Rationale

Newest-first pagination repeats 15 messages on the final page when a partition contains 25 messages.

What changed?

A regression test documents the overlap with passing controls for initial pages in both directions. The failing case is skipped pending agreement on the fix, following the contribution guidelines. The navigation query now passes through resolve() to satisfy lint without changing the destination.

Local Execution

  • Tests: 29 passed, 1 skipped. Enabling the regression test reproduces the failure.
  • Lint, formatting, build, and applicable prek hooks passed.
  • Type check: 0 errors, 29 existing warnings.
  • Confirmed in the browser with 25 real messages.

Document the final partial page overlap reported in apache#4717 with a skipped regression test and passing initial-page controls. Keep the implementation pending agreement on the issue. Pass the query through resolve so the existing navigation passes lint without changing its destination.
@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown

Thanks for the PR. It is labeled S-waiting-on-review and queued for review.

If AI was used to create this PR, you must run the team-review skill before opening it.

Slash commands (own line, regular comment) move it around the queue:

  • /ready - back to S-waiting-on-review after addressing feedback
  • /author - flip to S-waiting-on-author while you finish changes
  • /request-review @user-or-team - request a reviewer
  • /pin - exempt the PR from the stale bot, /unpin to undo

See CONTRIBUTING.md for details.

@ygndotgg

ygndotgg commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

@Subham-KRLX ,I reproduced #4717 locally and ran the regression test. This test reproduces the same overlap I observed in the UI. Given the staged migration to Dioxus planned in #4633 , could you check with the maintainers whether this issue should be fixed in the current UI? Please proceed based on their guidance

@hubcio

hubcio commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

lets merge this after #4644 (and all subsequent PRs leading to dioxus-based web-ui), maybe this bug doesnt exist there.

@ygndotgg

ygndotgg commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

/author

@github-actions github-actions Bot added S-waiting-on-author PR is waiting on author response and removed S-waiting-on-review PR is waiting on a reviewer labels Nov 4, 2026
@Subham-KRLX

Copy link
Copy Markdown
Contributor Author

I will hold off on the fix until the Dioxus migration lands then recheck pagination in the new UI and proceed based on maintainer guidance.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-author PR is waiting on author response

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants