feat(cpp): expose get and delete personal access tokens by Mitshah2406 · Pull Request #4628 · apache/iggy

Mitshah2406 · 2026-10-23T18:15:42Z

Which issue does this PR address?

Closes #4612

Rationale

A C++ app could not list or delete its personal access tokens, although the Rust SDK already supports both.

What changed?

Enabled the two bridge calls that were commented out, as GetPersonalAccessTokens() and DeletePersonalAccessToken(name). A failed delete fills Code(), Kind() and OperationId(), like DeleteUser.
Fixed the Rust SDK HTTP delete (core/sdk/src/http/personal_access_tokens.rs), which affects every Rust HTTP user. The token name went into the URL raw, so abc?x deleted abc and ../users/42 hit /users/42. The name is now percent-encoded, and . and .. are rejected with InvalidPersonalAccessTokenName, because the URL parser resolves them even when encoded.
Added unit tests for both and an e2e test that creates, lists, deletes and lists again.

Local Execution

Pre-commit hooks ran and passed

AI Usage

Which tools? Claude (Claude Code)
Scope of usage? Wrote the implementation and tests under my direction. Also used it to understand and review the code.
How did you verify the generated code works correctly? Ran clippy, the SDK and bridge tests, the Bazel unit tests and the C++ e2e suite against a local server (429 passed, 2 failed).
Can you explain every line of the code if asked? Yes.

github-actions · 2026-10-23T18:16:06Z

Note for maintainers: @Mitshah2406 also has #4617 open. New contributors are asked to keep one open PR at a time. See CONTRIBUTING.md.

slbotbm · 2026-10-24T06:49:24Z

@Mitshah2406 please edit your pr description to follow the repository template. Also, is this ready for review, or do you need to time?

Mitshah2406 · 2026-10-24T10:56:22Z

/ready

slbotbm · 2026-10-24T11:01:05Z

/skill team-review-slim

github-actions · 2026-10-24T11:01:28Z

No skill named team-review-slim on the default branch. Available here: connector-review, connector-runtime, connector-sdk, connector-sink, connector-source, connector-testing, connector-transform, connectors-overview, team-review.

codecov · 2026-10-24T11:16:56Z

Codecov Report

❌ Patch coverage is 80.82192% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.99%. Comparing base (4eccc5e) to head (9f4258f).
⚠️ Report is 25 commits behind head on master.

Files with missing lines	Patch %	Lines
core/sdk/src/http/personal_access_tokens.rs	47.05%	9 Missing ⚠️
foreign/cpp/src/client.cpp	75.00%	0 Missing and 3 partials ⚠️
foreign/cpp/src/type_conversions.cpp	60.00%	0 Missing and 2 partials ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (4eccc5e) and HEAD (9f4258f). Click for more details.

HEAD has 1 upload less than BASE

Flag BASE (4eccc5e) HEAD (9f4258f)

rust 4 3

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #4628      +/-   ##
============================================
- Coverage     90.87%   80.99%   -9.89%     
- Complexity     3104     3106       +2     
============================================
  Files          1482     1482              
  Lines        362179   362249      +70     
  Branches     306049   306071      +22     
============================================
- Hits         329117   293386   -35731     
- Misses        26144    61874   +35730     
- Partials       6918     6989      +71

Components	Coverage Δ
Rust Core	`80.32% <47.05%> (-11.89%)`	⬇️
Java SDK	`78.17% <ø> (+0.03%)`	⬆️
C# SDK	`83.56% <ø> (-0.04%)`	⬇️
Python SDK	`85.67% <ø> (ø)`
PHP SDK	`90.71% <ø> (ø)`
Node SDK	`96.44% <ø> (-0.01%)`	⬇️
Go SDK	`69.22% <ø> (-0.09%)`	⬇️
C++ SDK	`85.61% <91.07%> (+0.06%)`	⬆️

Files with missing lines	Coverage Δ
foreign/cpp/include/iggy.hpp	`89.84% <100.00%> (+0.03%)`	⬆️
foreign/cpp/src/client.rs	`87.87% <100.00%> (+0.25%)`	⬆️
foreign/cpp/src/lib.rs	`100.00% <ø> (ø)`
foreign/cpp/src/type_conversion.rs	`95.14% <100.00%> (+0.02%)`	⬆️
foreign/cpp/src/type_conversions.cpp	`65.48% <60.00%> (-0.05%)`	⬇️
foreign/cpp/src/client.cpp	`68.95% <75.00%> (+0.15%)`	⬆️
core/sdk/src/http/personal_access_tokens.rs	`64.00% <47.05%> (-36.00%)`	⬇️

... and 508 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

hubcio · 2026-10-24T12:45:57Z

/skill team-review

github-actions

Summary: The C++ binding adds personal access token listing and deletion in the existing bridge pattern, but the new delete call reaches an HTTP SDK path that writes the raw token name into the URL, so a name such as ../users/42 retargets the DELETE to another endpoint. The README error list and the delete method's outcome note are also inconsistent with the rest of the API.

Counts: critical 1, warning 0, nit 2, simplification 0

This review was generated by Claude Code 2.1.284 on deepseek-flash[1m]. Review the output before you act on it.

Mitshah2406 · 2026-10-25T08:21:43Z

/ready

hubcio

main gap is tests - nothing lists or deletes a real token, and nothing covers the new HTTP path encoding. a few things outside the diff:

the PR description only covers the C++ side - please mention the rust SDK fix in core/sdk/src/http/personal_access_tokens.rs, since it changes the delete path for everyone on the rust HTTP client.
foreign/cpp/README.md:103 still leaves DeletePersonalAccessToken out of the list of methods that fill Code() and Kind().
please open the issue you offered for C# and java - both HTTP clients still put the raw token name in the delete path (HttpMessageStream.cs:906, PersonalAccessTokensHttpClient.java:56).
follow-up, not this PR: core/sdk/src/http/users.rs:90 (also lines 37, 101, 114, 131) has the same raw-path bug, so DeleteUser("../streams/1") over HTTP sends DELETE /streams/1.
follow-up, not this PR: a token named login can't be deleted over HTTP - the POST-only /personal-access-tokens/login route in core/server/src/http.rs:409 wins over {name} and answers 405.

slbotbm · 2026-10-28T10:13:59Z

@Mitshah2406 could you rebase? create_personal_access_token's pr was merged. please use that function in the tests for the two functions you've added as well

Mitshah2406 · 2026-10-28T10:17:07Z

@Mitshah2406 could you rebase? create_personal_access_token's pr was merged. please use that function in the tests for the two functions you've added as well

Sure. Will do

Mitshah2406 · 2026-10-28T13:53:06Z

Thanks for the review, addressed all the points in the latest push.
I opened 3 issues as follow ups too:-
#4672 for the Java and C# clients
#4673 for users.rs
#4674 for the login / . / .. token names.

Mitshah2406 · 2026-10-28T13:55:35Z

/ready

…t failure

… tests

…t and delete test

Mitshah2406 · 2026-11-03T15:43:51Z

@hubcio please review whenever you get time.

hubcio

please address the issues below.

hubcio · 2026-11-04T18:15:23Z

 const PATH: &str = "/personal-access-tokens";

+fn delete_path(name: &str) -> String {
+    format!("{PATH}/{}", encode_segment(name))


warning: deleting a valid token named login over http hits the static, post-only /personal-access-tokens/login route instead of token deletion. route delete requests for that path to deletion and add a regression test.

noted, thanks for catching.. updating with a regression test.

Mitshah2406 force-pushed the feat-4612-cpp-sdk-pat-list-delete branch 2 times, most recently from cdd8986 to 8ba4dac Compare October 24, 2026 10:54

Mitshah2406 marked this pull request as ready for review October 24, 2026 10:56

github-actions Bot added the S-waiting-on-review PR is waiting on a reviewer label Oct 24, 2026

github-actions Bot reviewed Oct 24, 2026

View reviewed changes

Comment thread foreign/cpp/src/client.rs Resolved

Comment thread foreign/cpp/include/iggy.hpp Resolved

Comment thread foreign/cpp/include/iggy.hpp Resolved

github-actions Bot added S-waiting-on-author PR is waiting on author response and removed S-waiting-on-review PR is waiting on a reviewer labels Oct 24, 2026

github-actions Bot added S-waiting-on-review PR is waiting on a reviewer and removed S-waiting-on-author PR is waiting on author response labels Oct 25, 2026

hubcio requested changes Oct 26, 2026

View reviewed changes

github-actions Bot added S-waiting-on-author PR is waiting on author response and removed S-waiting-on-review PR is waiting on a reviewer labels Oct 26, 2026

Mitshah2406 force-pushed the feat-4612-cpp-sdk-pat-list-delete branch from 092a0db to 913af66 Compare October 28, 2026 13:26

This was referenced Oct 28, 2026

fix(java,csharp): personal access token name is not escaped in the HTTP delete path #4672

Open

fix(sdk): user id is not escaped in HTTP paths in users.rs #4673

Open

fix(server): personal access tokens named login, . or .. can't be deleted over HTTP #4674

Open

github-actions Bot added S-waiting-on-review PR is waiting on a reviewer and removed S-waiting-on-author PR is waiting on author response labels Oct 28, 2026

Mitshah2406 added 6 commits October 29, 2026 19:50

feat(cpp): expose get and delete personal access tokens

5954bba

fix(cpp): report error details from DeletePersonalAccessToken

d7d7e30

fix(sdk): percent-encode the token name in the HTTP delete path

07c401b

docs(cpp): warn that DeletePersonalAccessToken may commit on transpor…

52c5f65

…t failure

fix(cpp): address review on PAT list/delete, reject dot names and add…

01d9f7b

… tests

test(cpp): create the token with CreatePersonalAccessToken in the lis…

3bab3db

…t and delete test

Mitshah2406 force-pushed the feat-4612-cpp-sdk-pat-list-delete branch from 3cd24c7 to 3bab3db Compare October 29, 2026 14:27

Merge branch 'master' into feat-4612-cpp-sdk-pat-list-delete

9f4258f

Mitshah2406 requested a review from hubcio October 31, 2026 10:24

hubcio requested changes Nov 4, 2026

View reviewed changes

github-actions Bot added S-waiting-on-author PR is waiting on author response and removed S-waiting-on-review PR is waiting on a reviewer labels Nov 4, 2026

Mitshah2406 added 2 commits November 6, 2026 13:50

fix(server): allow deleting a PAT named login over HTTP

06fef5d

Merge branch 'master' into feat-4612-cpp-sdk-pat-list-delete

2536210

Conversation

Mitshah2406 commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Which issue does this PR address?

Rationale

What changed?

Local Execution

AI Usage

Uh oh!

github-actions Bot commented Oct 23, 2026

Uh oh!

slbotbm commented Oct 24, 2026

Uh oh!

Mitshah2406 commented Oct 24, 2026

Uh oh!

slbotbm commented Oct 24, 2026

Uh oh!

github-actions Bot commented Oct 24, 2026

Uh oh!

codecov Bot commented Oct 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

hubcio commented Oct 24, 2026

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Mitshah2406 commented Oct 25, 2026

Uh oh!

hubcio left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

slbotbm commented Oct 28, 2026

Uh oh!

Mitshah2406 commented Oct 28, 2026

Uh oh!

Mitshah2406 commented Oct 28, 2026

Uh oh!

Mitshah2406 commented Oct 28, 2026

Uh oh!

Mitshah2406 commented Nov 3, 2026

Uh oh!

hubcio left a comment

Choose a reason for hiding this comment

Uh oh!

hubcio Nov 4, 2026

Choose a reason for hiding this comment

Uh oh!

Mitshah2406 Nov 4, 2026

Choose a reason for hiding this comment

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Mitshah2406 commented Oct 23, 2026 •

edited

Loading

codecov Bot commented Oct 24, 2026 •

edited

Loading