Site: [lottie][cpu] limit lottie cpu burning to actual visibility - #18107
Open
rmannibucau wants to merge 1 commit into
Open
rmannibucau wants to merge 1 commit into
rmannibucau wants to merge 1 commit into
Conversation
rmannibucau
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up of the list issue with the home page eating 100% of one core.
Since dropping the animation is not an option and the lottie json file is not friendly with the canvas renderer (which consumes less than svg one) I went with hidding/disabling the animation when not visible. Solves the issue until you scroll until the animation and stay there (not default case).