Repository navigation
fix(api): clarify indexed resource paths - #3431
Merged
Merged
Conversation
added 2 commits
October 28, 2026 16:55
Return origin-relative paths from the API resource index. Normalize root and child paths to avoid duplicate slashes. Cover index resolution and document graph aliases and long queries.
This was referenced Oct 28, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3431 +/- ##
============================================
+ Coverage 57.27% 57.44% +0.17%
- Complexity 6577 6945 +368
============================================
Files 776 776
Lines 68881 68777 -104
Branches 9431 9411 -20
============================================
+ Hits 39449 39512 +63
+ Misses 25804 25643 -161
+ Partials 3628 3622 -6
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Map a missing label builder result to a not-found response. Preserve task IDs for successful vertex, edge and index rebuilds. Cover API behavior and document submission and error semantics.
This was referenced Oct 28, 2026
bitflicker64
left a comment
bitflicker64
left a comment
Contributor
There was a problem hiding this comment.
Blocking: yes. Summary: the RebuildAPI 404 mapping is correct, but /apis entries start at / and drop the context path that restserver.url can set, so they stop resolving on such deployments.
MrJs133
previously approved these changes
Oct 29, 2026
MrJs133
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before → After
Before:
/apisexposes relative resource names that can resolve to nonexistent/apis/...routes, and root child indexing can produce a double slash.After: Return normalized root-relative API paths and add index-resolution/parameter regression coverage. Document verified graphspace Gremlin aliases and asynchronous-job usage.
Validation boundary
The source author reports a 38-module clean compile, six focused tests, and a live RocksDB Server alias check. These are author-reported results, not independent end-to-end acceptance; current upstream CI must be evaluated separately. Paired bilingual website documentation: 🔗 hugegraph/hugegraph-doc #56.
Related issue: hugegraph/hugegraph-toolchain#103
Source PR: 🔗 hugegraph/hugegraph #354
Visual overview
API index paths resolve from the Server origin rather than /apis/. Root-child joining avoids duplicate slashes; GraphSpace aliases document existing bindings, and clients retain any gateway prefix. Design illustration, not full HTTP acceptance.