Skip to content

feat(api): support adamic-adar & resource-allocation algorithms - #1763

Merged
javeme merged 3 commits into
masterfrom
aa-rs
Mar 18, 2022
Merged

javeme merged 3 commits into
masterfrom
aa-rs

Conversation

@imbajin

@imbajin imbajin commented Feb 21, 2022

Copy link
Copy Markdown
Member

TODO:

  • add test in client side

@codecov

codecov Bot commented Feb 21, 2022 •

Copy link
Copy Markdown

Codecov Report

Merging #1763 (3fea9a5) into master (5cdf770) will increase coverage by 3.62%.
The diff coverage is 89.09%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1763      +/-   ##
============================================
+ Coverage     63.26%   66.88%   +3.62%     
- Complexity      684      976     +292     
============================================
  Files           443      446       +3     
  Lines         37738    37791      +53     
  Branches       5381     5389       +8     
============================================
+ Hits          23875    25278    +1403     
+ Misses        11247     9785    -1462     
- Partials       2616     2728     +112     
Impacted Files Coverage Δ
...graph/traversal/algorithm/PredictionTraverser.java 86.66% <86.66%> (ø)
...ugegraph/api/traversers/ResourceAllocationAPI.java 90.90% <90.90%> (ø)
.../baidu/hugegraph/api/traversers/AdamicAdarAPI.java 91.66% <91.66%> (ø)
...api/src/main/java/com/baidu/hugegraph/api/API.java 75.00% <100.00%> (ø)
...n/java/com/baidu/hugegraph/version/ApiVersion.java 75.00% <100.00%> (ø)
.../baidu/hugegraph/backend/query/ConditionQuery.java 84.90% <0.00%> (+0.24%) ⬆️
...om/baidu/hugegraph/backend/store/BackendTable.java 82.00% <0.00%> (+0.66%) ⬆️
...a/com/baidu/hugegraph/backend/query/Condition.java 77.61% <0.00%> (+0.72%) ⬆️
...in/java/com/baidu/hugegraph/StandardHugeGraph.java 65.90% <0.00%> (+0.87%) ⬆️
...in/java/com/baidu/hugegraph/backend/id/EdgeId.java 77.67% <0.00%> (+0.89%) ⬆️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cdf770...3fea9a5. Read the comment docs.


double sum = 0.0;
for (Id vid : neighbors) {
sum += 1.0 / this.edgesCount(vid, step);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may this.edgesCount() return 0

@imbajin imbajin Feb 22, 2022 •

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why common neighbor vertex's degree could be zero? seems at least is 2?

@javeme
javeme merged commit 0ca54c4 into master Mar 18, 2022
@javeme
javeme deleted the aa-rs branch March 18, 2022 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants