[Bug] PD PartitionCache lockGraph method opposite to the expected behavior. #2639

Activity

1. haohao0103

   added

   bugSomething isn't workingSomething isn't working

   on Aug 14, 2024
2. dosubot commented on Aug 14, 2024

   

   dosubotBot

   on Aug 14, 2024 – with DosuBot

   More actions

   To fix the logic design issue in the lockGraph method of the PartitionCache class, you need to change the condition in the while loop. The compareAndSet method returns true if it successfully sets the value, meaning the lock was acquired, so the loop should exit. The correct condition should be !lock.compareAndSet(false, true).

   Here is the corrected lockGraph method:

   public void lockGraph(String graphName) {
       var lock = getOrCreateGraphLock(graphName);
       while (!lock.compareAndSet(false, true)) {
           Thread.onSpinWait();
       }
   }

   This change ensures that the loop will continue spinning only if the compareAndSet method fails to acquire the lock ^[1].

   To continue talking to Dosu, mention @dosu.

   👍React with 👍1Reacted by imbajin
3. haohao0103

   added a commit that references this issue on Aug 14, 2024

   close apache#2639

   This issue will close once commit 6148c6f is merged into the 'master' branch.

   6148c6f
4. imbajin

   closed this as completedin #2640on Sep 24, 2024