Repository navigation
[Bug] Dockerfile does not build, does not line up with conf/rest-server.properties #2015
Description
Bug Type (问题类型)
other exception / error (其他异常报错)
Before submit
Environment (环境信息)
- Server Version: v0.12.0
- Backend: N/A
- OS: Fedora 37 Workstation
- Data Size: N/A
Expected & Actual behavior (期望与实际表现)
Expected
I should be able to clone this repo and run docker build . with no errors. Command should result in a built container.
Actual
See my comments on the commit associated with #1901
The sed line numbers referencing the server's default conf/rest-server.properties were updated for 0.12.0 but appears to still be off by one line. Simply changing it to 66p and 76p respectively allow me to build the container.
I would be happy to submit a PR for this simple fix, but wanted to make sure that I was in the right and that my problem was reproducible before doing so.
Vertex/Edge example (问题点 / 边数据举例)
N/ASchema [VertexLabel, EdgeLabel, IndexLabel] (元数据结构)
N/A
Activity
imbajin commentedon Nov 13, 2022
thanks for your report, @simon824 could u help to check it?
we should use the latest code to build automatically (while release the first apache version 1.0.0)
and
sedis not a good way (due to the hard code), consider add a option (-fgto run not in background), and welcome to contribute & enhance it (could refer this issue to see the TODOs #840 )simon824 commentedon Nov 14, 2022
Hi @baughmann ,refer to v0.12.0-b1, you can change it to 66p and 76p, but as @imbajin said, sed is not a good way, maybe you can improve it if you are interested.
baughmann commentedon Nov 15, 2022
@imbajin @simon824 Thanks for getting back to me, guys.
I am not yet sure when I can get around to it. I know I just said two days ago that I would be happy to submit a PR, but a few things have changed on my end since. Turns out we will no longer be using HugeGraph (at least for now...)
Best I can hope to do is through another bash hack in there, but please don't wait on me :(
Were you able to replicate this behavior on your end, Simon?
simon824 commentedon Nov 15, 2022
ok, good luck @baughmann
baughmann commentedon Nov 17, 2022
@simon824 Just to reiterate this is not something I'm actively working on, unfortunately.
Were you able to replicate the bug, or is it just me?
imbajin commentedon Nov 22, 2022
I'll address this issue soon, and push a stable version to
Dockerhubor Apache's image repoimbajin commentedon Nov 29, 2022
Update:
I do can repeat this problem, maybe the download link
0.12is not related with the branch0.12(maybe with0.12-xx)And I will update the script & use the latest code to avoid hard code the line, thanks @baughmann for report it
imbajin commentedon Mar 17, 2023
This problem fixed in #2118, and we update the usage doc in
README& Dockerhub for usersThanks for the report again. (Docker TODOs summary in issue $840)