Repository navigation
[hotfix][plan] Upgrade tree-sitter to 0.26.6 - #1293
Merged
Merged
Conversation
Generated-by: Claude Code 2.1.303 (Claude Opus 5.5)
2 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue: #1289
Purpose of change
When tree-sitter 0.25.3 has to extract its native library, it writes it under
FileChannel.lock(), and that lock throws on an already interrupted thread.TSParser's static initializer then fails and the class stays unusable in that class loader (#1289).ut-javafails this way whenBashToolTest#interruptionPropagatesInsteadOfReturningToolResultis the first test to create a parser and the library has to be extracted. 0.26.6 extracts the library to a temporary file without the lock (bonede/tree-sitter-ng#133), as @wenjin272 suggested in #1289. Neither version declares dependencies, soMETA-INF/NOTICEonly gets the new version. This supersedes the test-only warm-up in #1290.Tests
Locally on macOS arm64:
FileLockInterruptionExceptionandExceptionInInitializerError.BashToolTest(8) andBashValidatorTest(16) pass on all three JDKs withtree-sitter-bash:0.23.3.planmodule on JDK 17: 649 tests, 0 failures, 3 skipped, and 8 errors, all inAgentPlanDeclareMCPServerTest(MCP initialization returns HTTP 404 locally), which fails the same way on main with 0.25.3.API
No.
Documentation
doc-neededdoc-not-neededdoc-includedWas this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code 2.1.303 (Claude Opus 5.5)