Skip to content

[Feature] Separate messages and arguments for prompt of chat method in BaseChatModelSetup #220

Closed

Description

@wenjin272

Search before asking

  • I searched in the issues and found nothing similar.

Description

Currently, the chat method in BaseChatModelSetup will get arguments from messages extra_args to fill the prompt template, which is not clear.

Are you willing to submit a PR?

  • I'm willing to submit a PR!

Activity

  1. added
    feature[Issue Type] New features or improvements to existing features.
    on Sep 26, 2025
  2. added
    priority/majorDefault priority of the PR or issue.
    fixVersion/0.2.0The feature or bug should be implemented/fixed in the 0.2.0 version.
    on Nov 14, 2025
  3. removed
    fixVersion/0.2.0The feature or bug should be implemented/fixed in the 0.2.0 version.
    on Jan 8, 2026
  4. weiqingy commented on May 20, 2026

    @weiqingy
    Collaborator

    @wenjin272 I came up with a change proposal on this https://github.com/weiqingy/flink-agents/blob/220-design-review/docs/PR-220/220-DESIGN.md Could you please take a look when you get a chance? If it looks good to you, I can help work on this.

  5. weiqingy commented on May 22, 2026

    @weiqingy
    Collaborator

    @wenjin272 The PR has been created: #698 . Could you take a look when you get a chance? Thanks!

  6. added
    fixVersion/0.3.0The feature or bug should be implemented/fixed in the 0.3.0 version.
    and removed
    fixVersion/missingThe Bot applies this label when fixVersion is not set.
    on Jun 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

feature[Issue Type] New features or improvements to existing features.fixVersion/0.3.0The feature or bug should be implemented/fixed in the 0.3.0 version.priority/majorDefault priority of the PR or issue.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions