Skip to content

docs(#5295): add package-level doc for RocketMQ 5 POP broker-ACK barrier (PR #5316) #5334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qqeasonchen merged 1 commit into from
Sep 7, 2026
Merged

docs(#5295): add package-level doc for RocketMQ 5 POP broker-ACK barrier (PR #5316) #5334

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/ingress/package-info.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,16 @@
*
* <p>Policy: Public facade -- boot wires ingress into UniRuntime, but no engine sub-package may bypass it.
*
* <p>Broker-ACK barrier (RocketMQ 5.x POP, see PR #5316 by zhang-arvin,
* fixes #5295): when the ingress frame carries a POP check key (the
* {@code empopck} attribute), deliveries to all matched subscriptions
* share an {@link java.util.concurrent.atomic.AtomicInteger} counter
* initialized to the target count; the broker is ACKed (via
* {@code storage.ackPulledMessage}) only when the last required delivery
* ACKs. This restores at-least-once semantics across LOAD_BALANCE,
* BROADCAST, and MULTICAST distribution modes. Frames without
* {@code empopck} bypass the barrier (no broker ACK to defer).
*
* <p>Marked {@link org.apache.eventmesh.common.Internal @Internal} as a
* whole package; public types must carry {@link org.apache.eventmesh.common.Public @Public}.
*/
Expand Down