Repository navigation

fix(9678): short circuiting prevented population of visited stack, for common subexpr elimination optimization - #9685

Merged

alamb merged 11 commits into

apache:mainfrom

wiedld:9678/common-subexpr-eliminate

Mar 21, 2024

Merged

fix(9678): short circuiting prevented population of visited stack, for common subexpr elimination optimization#9685
alamb merged 11 commits into
apache:mainfrom
wiedld:9678/common-subexpr-eliminate

Commits on Mar 18, 2024
- test(9678): reproducer of short-circuiting causing expr elimination to error
  wiedld
  committed
  f1a01eb
- fix(9678): populate visited stack for short-circuited expressions, during the common-expr elimination optimization
  wiedld
  committed
  ff46614
Commits on Mar 19, 2024
- test(9678): reproducer for optimizer error (in common_subexpr_eliminate), as seen in other test case
  wiedld
  committed
  de09f72
Commits on Mar 20, 2024
- chore: extract id_array into abstraction, to make it more clear the relationship between the two visitors
  wiedld
  committed
  97938ad
- refactor: tweak the fix and make code more explicit (JumpMark, node_to_identifier)
  wiedld
  committed
  1931b3b
- fix: get the series_number and curr_id with the correct self.current_idx, before the various incr/decr
  wiedld
  committed
  552e0f4
- chore: remove unneeded conditional check (already done earlier), and add code comments
  wiedld
  committed
  a55ced4
- Refine documentation in common_subexpr_eliminate.rs
  alamb
  committed
  04ddb6e
- chore: Refine documentation in common_subexpr_eliminate
  wiedld
  authored
  104eeb7
- chore: cleanup -- fix 1 doc comment and consolidate common-expr-elimination test with other expr test
  wiedld
  committed
  6223239
Commits on Mar 21, 2024
- Merge remote-tracking branch 'apache/main' into 9678/common-subexpr-eliminate
  alamb
  committed
  8013ca6