Repository navigation
Causality Analysis for Builtin Window Functions - #9048
Merged
Merged
Conversation
Co-authored-by: Mehmet Ozan Kabak <ozankabak@gmail.com>
# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
github-actions
Bot
added
logical-expr
mustafasrepo
changed the title
comphead
approved these changes
Jan 29, 2024
comphead
left a comment
comphead
left a comment
Contributor
There was a problem hiding this comment.
lgtm thanks @mustafasrepo
1 of 6 tasks
Contributor
|
Since this is a fairly simple change, I will go ahead and merge it (hence we can utilize @alamb's review cycles more effectively) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
In the PR8842 causality (analysis whether window frame need future values to calculate its result. Similar to signal processing terminology) support for window frame is introduced. Although most of the window functions uses window frame to determine its necessary rows. Some of the window functions do not use window frame to determine necessary rows for its result (such as
ROW_NUMBER,RANK,LEAD,LAG, etc.)This PR adds causality analysis support for these window functions. With the changes introduced in this PR, we can generate results for these window functions earlier.
What changes are included in this PR?
Are these changes tested?
Yes
Are there any user-facing changes?