Repository navigation
[MINOR]: Add size check for aggregate - #8813
Merged
Merged
Conversation
metesynnada
approved these changes
Jan 10, 2024
metesynnada
left a comment
metesynnada
left a comment
Contributor
There was a problem hiding this comment.
Simple change, LGTM.
alamb
approved these changes
Jan 10, 2024
alamb
left a comment
alamb
left a comment
Contributor
There was a problem hiding this comment.
Thank you @mustafasrepo and @metesynnada
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
Aggregate algorithm depends on
aggr_expr.lenandfilter_expr.len()being the same (They are iterated simultaneously withzip). As far as I know, their sizes cannot have different sizes from an SQL query.However, while writing unit tests, one can easily forget this invariant. This PR adds check for this assumption.
What changes are included in this PR?
With this check, I recognized some of the unit tests, didn't consider this invariant. This PR fixes these tests also.
Are these changes tested?
Are there any user-facing changes?