Repository navigation
MINOR: Improve optimizer error - #3403
Merged
Merged
Conversation
ayushdg
approved these changes
Sep 8, 2022
ayushdg
left a comment
ayushdg
left a comment
Contributor
There was a problem hiding this comment.
Thanks, this should make debugging some failures from the planner easier
alamb
approved these changes
Sep 8, 2022
Dandandan
approved these changes
Sep 8, 2022
Contributor
|
Thanks @andygrove |
|
Benchmark runs are scheduled for baseline = 1b40ffa and contender = 3987117. 3987117 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Smallfu666
pushed a commit
to Smallfu666/datafusion
that referenced
this pull request
Aug 14, 2026
Bumps [pygithub](https://github.com/pygithub/pygithub) from 2.8.1 to 2.9.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/pygithub/pygithub/releases">pygithub's releases</a>.</em></p> <blockquote> <h2>v2.9.1</h2> <h3>Bug Fixes</h3> <ul> <li>Fix getting release by tag in lazy mode by <a href="https://github.com/EnricoMi"><code>@EnricoMi</code></a> in <a href="https://redirect.github.com/PyGithub/PyGithub/pull/3469">PyGithub/PyGithub#3469</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/PyGithub/PyGithub/compare/v2.9.0...v2.9.1">https://github.com/PyGithub/PyGithub/compare/v2.9.0...v2.9.1</a></p> <h2>v2.9.0</h2> <h3>Notable changes</h3> <h4>Lazy PyGithub objects</h4> <p>The notion of lazy objects has been added to some PyGithub classes in version 2.6.0. This release now makes all <code>CompletableGithubObject</code>s optionally lazy (if useful). See <a href="https://redirect.github.com/PyGithub/PyGithub/pull/3403">PyGithub/PyGithub#3403</a> for a complete list.</p> <p>In lazy mode, getting a PyGithub object does not send a request to the GitHub API. Only accessing methods and properties sends the necessary requests to the GitHub API:</p> <pre lang="python"><code># Use lazy mode g = Github(auth=auth, lazy=True) <h1>these method calls do not send requests to the GitHub API</h1> <p>user = g.get_user("PyGithub") # get the user repo = user.get_repo("PyGithub") # get the user's repo pull = repo.get_pull(3403) # get a known pull request issue = pull.as_issue() # turn the pull request into an issue</p> <h1>these method and property calls send requests to Github API</h1> <p>issue.create_reaction("rocket") # create a reaction created = repo.created_at # get property of lazy object repo</p> <h1>once a lazy object has been fetched, all properties are available (no more requests)</h1> <p>licence = repo.license </code></pre></p> <p>All PyGithub classes that implement <code>CompletableGithubObject</code> support lazy mode (if useful). This is only useful for classes that have methods creating, changing, or getting objects.</p> <p>By default, PyGithub objects are not lazy.</p> <h4>PyGithub objects with a paginated property</h4> <p>The GitHub API has the "feature" of paginated properties. Some objects returned by the API have a property that allows for pagination. Fetching subsequent pages of that property means fetching the entire object (with all other properties) and the specified page of the paginated property. Iterating over the paginated property means fetching all other properties multiple times. Fortunately, the allowed size of each page (<code>per_page</code> is usually 300, in contrast to the "usual" <code>per_page</code> maximum of 100).</p> <p>Objects with paginated properties:</p> <ul> <li>Commit.files</li> <li>Comparison.commits</li> <li>EnterpriseConsumedLicenses.users</li> </ul> <p>This PR makes iterating those paginated properties use the configured <code>per_page</code> setting.</p> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/PyGithub/PyGithub/blob/main/doc/changes.rst">pygithub's changelog</a>.</em></p> <blockquote> <h2>Version 2.9.1 (April 14, 2026)</h2> <p>Bug Fixes ^^^^^^^^^</p> <ul> <li>Fix getting release by tag in lazy mode (<code>[apache#3469](PyGithub/PyGithub#3469) <https://github.com/PyGithub/PyGithub/pull/3469></code><em>) (<code>7d1ba281e <https://github.com/PyGithub/PyGithub/commit/7d1ba281e></code></em>)</li> </ul> <h2>Version 2.9.0 (March 22, 2026)</h2> <p>Notable changes ^^^^^^^^^^^^^^^</p> <p>Lazy PyGithub objects """""""""""""""""""""</p> <p>The notion of lazy objects has been added to some PyGithub classes in version 2.6.0. This release now makes all <code>CompletableGithubObject</code>\s optionally lazy (if useful). See <code>[apache#3403](PyGithub/PyGithub#3403) <https://github.com/PyGithub/PyGithub/pull/3403></code>_ for a complete list.</p> <p>In lazy mode, getting a PyGithub object does not send a request to the GitHub API. Only accessing methods and properties sends the necessary requests to the GitHub API:</p> <p>.. code-block:: python</p> <pre><code># Use lazy mode g = Github(auth=auth, lazy=True) <h1>these method calls do not send requests to the GitHub API</h1> <p>user = g.get_user("PyGithub") # get the user repo = user.get_repo("PyGithub") # get the user's repo pull = repo.get_pull(3403) # get a known pull request issue = pull.as_issue() # turn the pull request into an issue</p> <h1>these method and property calls send requests to Github API</h1> <p>issue.create_reaction("rocket") # create a reaction created = repo.created_at # get property of lazy object repo</p> <h1>once a lazy object has been fetched, all properties are available (no more requests)</h1> <p>licence = repo.license </code></pre></p> <p>All PyGithub classes that implement <code>CompletableGithubObject</code> support lazy mode (if useful). This is only useful for classes that have methods creating, changing, or getting objects.</p> <p>By default, PyGithub objects are not lazy.</p> <p>PyGithub objects with a paginated property """"""""""""""""""""""""""""""""""""""""""</p> <p>The GitHub API has the "feature" of paginated properties.</p> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/PyGithub/PyGithub/commit/73742d410da73e44a477b0e3f05dfba1749022af"><code>73742d4</code></a> Release 2.9.1 (<a href="https://redirect.github.com/pygithub/pygithub/issues/3478">#3478</a>)</li> <li><a href="https://github.com/PyGithub/PyGithub/commit/7d1ba281e4bf02cb6d3772f11b17c7d6088052d8"><code>7d1ba28</code></a> Fix getting release by tag in lazy mode (<a href="https://redirect.github.com/pygithub/pygithub/issues/3469">#3469</a>)</li> <li><a href="https://github.com/PyGithub/PyGithub/commit/3a17ecf4a5a4dc873f2632470a712497b38eea88"><code>3a17ecf</code></a> Release 2.9.0 (<a href="https://redirect.github.com/pygithub/pygithub/issues/3465">#3465</a>)</li> <li><a href="https://github.com/PyGithub/PyGithub/commit/b1a9b7e2a37b515b141e01091b7c964ff883fe1e"><code>b1a9b7e</code></a> Consider per-page settings when iterating paginated properties (<a href="https://redirect.github.com/pygithub/pygithub/issues/3377">#3377</a>)</li> <li><a href="https://github.com/PyGithub/PyGithub/commit/24305f6d60869a849dadd0d271b4753ceac3658d"><code>24305f6</code></a> Update test key pair (<a href="https://redirect.github.com/pygithub/pygithub/issues/3453">#3453</a>)</li> <li><a href="https://github.com/PyGithub/PyGithub/commit/f2540db50423aa124beaeb8c7bfba7098a549c82"><code>f2540db</code></a> Deprecate <code>Reaction.delete</code> (<a href="https://redirect.github.com/pygithub/pygithub/issues/3435">#3435</a>)</li> <li><a href="https://github.com/PyGithub/PyGithub/commit/19e1c5032397a95c58fe25760723ffc24cbe0ec8"><code>19e1c50</code></a> Add <code>throw</code> option to <code>Workflow.create_dispatch</code> to raise exceptions (<a href="https://redirect.github.com/pygithub/pygithub/issues/2966">#2966</a>)</li> <li><a href="https://github.com/PyGithub/PyGithub/commit/646190988f3dd18e790969868b9ffe3c71acf254"><code>6461909</code></a> Add Secret Scanning Alerts and Improve Code Scan Alerts (<a href="https://redirect.github.com/pygithub/pygithub/issues/3307">#3307</a>)</li> <li><a href="https://github.com/PyGithub/PyGithub/commit/95648db4780e977b5bad8c19f669ec3f8c2b1a49"><code>95648db</code></a> Add Python 3.14 to CI and tox (<a href="https://redirect.github.com/pygithub/pygithub/issues/3429">#3429</a>)</li> <li><a href="https://github.com/PyGithub/PyGithub/commit/3716bab10b7a99445ef50d698d6b2d681620ac88"><code>3716bab</code></a> Use <code>GET</code> url or <code>_links.self</code> as object url (<a href="https://redirect.github.com/pygithub/pygithub/issues/3421">#3421</a>)</li> <li>Additional commits viewable in <a href="https://github.com/pygithub/pygithub/compare/v2.8.1...v2.9.1">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
imtherealnaska
pushed a commit
to imtherealnaska/datafusion
that referenced
this pull request
Aug 16, 2026
Bumps [pygithub](https://github.com/pygithub/pygithub) from 2.8.1 to 2.9.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/pygithub/pygithub/releases">pygithub's releases</a>.</em></p> <blockquote> <h2>v2.9.1</h2> <h3>Bug Fixes</h3> <ul> <li>Fix getting release by tag in lazy mode by <a href="https://github.com/EnricoMi"><code>@EnricoMi</code></a> in <a href="https://redirect.github.com/PyGithub/PyGithub/pull/3469">PyGithub/PyGithub#3469</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/PyGithub/PyGithub/compare/v2.9.0...v2.9.1">https://github.com/PyGithub/PyGithub/compare/v2.9.0...v2.9.1</a></p> <h2>v2.9.0</h2> <h3>Notable changes</h3> <h4>Lazy PyGithub objects</h4> <p>The notion of lazy objects has been added to some PyGithub classes in version 2.6.0. This release now makes all <code>CompletableGithubObject</code>s optionally lazy (if useful). See <a href="https://redirect.github.com/PyGithub/PyGithub/pull/3403">PyGithub/PyGithub#3403</a> for a complete list.</p> <p>In lazy mode, getting a PyGithub object does not send a request to the GitHub API. Only accessing methods and properties sends the necessary requests to the GitHub API:</p> <pre lang="python"><code># Use lazy mode g = Github(auth=auth, lazy=True) <h1>these method calls do not send requests to the GitHub API</h1> <p>user = g.get_user("PyGithub") # get the user repo = user.get_repo("PyGithub") # get the user's repo pull = repo.get_pull(3403) # get a known pull request issue = pull.as_issue() # turn the pull request into an issue</p> <h1>these method and property calls send requests to Github API</h1> <p>issue.create_reaction("rocket") # create a reaction created = repo.created_at # get property of lazy object repo</p> <h1>once a lazy object has been fetched, all properties are available (no more requests)</h1> <p>licence = repo.license </code></pre></p> <p>All PyGithub classes that implement <code>CompletableGithubObject</code> support lazy mode (if useful). This is only useful for classes that have methods creating, changing, or getting objects.</p> <p>By default, PyGithub objects are not lazy.</p> <h4>PyGithub objects with a paginated property</h4> <p>The GitHub API has the "feature" of paginated properties. Some objects returned by the API have a property that allows for pagination. Fetching subsequent pages of that property means fetching the entire object (with all other properties) and the specified page of the paginated property. Iterating over the paginated property means fetching all other properties multiple times. Fortunately, the allowed size of each page (<code>per_page</code> is usually 300, in contrast to the "usual" <code>per_page</code> maximum of 100).</p> <p>Objects with paginated properties:</p> <ul> <li>Commit.files</li> <li>Comparison.commits</li> <li>EnterpriseConsumedLicenses.users</li> </ul> <p>This PR makes iterating those paginated properties use the configured <code>per_page</code> setting.</p> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/PyGithub/PyGithub/blob/main/doc/changes.rst">pygithub's changelog</a>.</em></p> <blockquote> <h2>Version 2.9.1 (April 14, 2026)</h2> <p>Bug Fixes ^^^^^^^^^</p> <ul> <li>Fix getting release by tag in lazy mode (<code>[apache#3469](PyGithub/PyGithub#3469) <https://github.com/PyGithub/PyGithub/pull/3469></code><em>) (<code>7d1ba281e <https://github.com/PyGithub/PyGithub/commit/7d1ba281e></code></em>)</li> </ul> <h2>Version 2.9.0 (March 22, 2026)</h2> <p>Notable changes ^^^^^^^^^^^^^^^</p> <p>Lazy PyGithub objects """""""""""""""""""""</p> <p>The notion of lazy objects has been added to some PyGithub classes in version 2.6.0. This release now makes all <code>CompletableGithubObject</code>\s optionally lazy (if useful). See <code>[apache#3403](PyGithub/PyGithub#3403) <https://github.com/PyGithub/PyGithub/pull/3403></code>_ for a complete list.</p> <p>In lazy mode, getting a PyGithub object does not send a request to the GitHub API. Only accessing methods and properties sends the necessary requests to the GitHub API:</p> <p>.. code-block:: python</p> <pre><code># Use lazy mode g = Github(auth=auth, lazy=True) <h1>these method calls do not send requests to the GitHub API</h1> <p>user = g.get_user("PyGithub") # get the user repo = user.get_repo("PyGithub") # get the user's repo pull = repo.get_pull(3403) # get a known pull request issue = pull.as_issue() # turn the pull request into an issue</p> <h1>these method and property calls send requests to Github API</h1> <p>issue.create_reaction("rocket") # create a reaction created = repo.created_at # get property of lazy object repo</p> <h1>once a lazy object has been fetched, all properties are available (no more requests)</h1> <p>licence = repo.license </code></pre></p> <p>All PyGithub classes that implement <code>CompletableGithubObject</code> support lazy mode (if useful). This is only useful for classes that have methods creating, changing, or getting objects.</p> <p>By default, PyGithub objects are not lazy.</p> <p>PyGithub objects with a paginated property """"""""""""""""""""""""""""""""""""""""""</p> <p>The GitHub API has the "feature" of paginated properties.</p> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/PyGithub/PyGithub/commit/73742d410da73e44a477b0e3f05dfba1749022af"><code>73742d4</code></a> Release 2.9.1 (<a href="https://redirect.github.com/pygithub/pygithub/issues/3478">#3478</a>)</li> <li><a href="https://github.com/PyGithub/PyGithub/commit/7d1ba281e4bf02cb6d3772f11b17c7d6088052d8"><code>7d1ba28</code></a> Fix getting release by tag in lazy mode (<a href="https://redirect.github.com/pygithub/pygithub/issues/3469">#3469</a>)</li> <li><a href="https://github.com/PyGithub/PyGithub/commit/3a17ecf4a5a4dc873f2632470a712497b38eea88"><code>3a17ecf</code></a> Release 2.9.0 (<a href="https://redirect.github.com/pygithub/pygithub/issues/3465">#3465</a>)</li> <li><a href="https://github.com/PyGithub/PyGithub/commit/b1a9b7e2a37b515b141e01091b7c964ff883fe1e"><code>b1a9b7e</code></a> Consider per-page settings when iterating paginated properties (<a href="https://redirect.github.com/pygithub/pygithub/issues/3377">#3377</a>)</li> <li><a href="https://github.com/PyGithub/PyGithub/commit/24305f6d60869a849dadd0d271b4753ceac3658d"><code>24305f6</code></a> Update test key pair (<a href="https://redirect.github.com/pygithub/pygithub/issues/3453">#3453</a>)</li> <li><a href="https://github.com/PyGithub/PyGithub/commit/f2540db50423aa124beaeb8c7bfba7098a549c82"><code>f2540db</code></a> Deprecate <code>Reaction.delete</code> (<a href="https://redirect.github.com/pygithub/pygithub/issues/3435">#3435</a>)</li> <li><a href="https://github.com/PyGithub/PyGithub/commit/19e1c5032397a95c58fe25760723ffc24cbe0ec8"><code>19e1c50</code></a> Add <code>throw</code> option to <code>Workflow.create_dispatch</code> to raise exceptions (<a href="https://redirect.github.com/pygithub/pygithub/issues/2966">#2966</a>)</li> <li><a href="https://github.com/PyGithub/PyGithub/commit/646190988f3dd18e790969868b9ffe3c71acf254"><code>6461909</code></a> Add Secret Scanning Alerts and Improve Code Scan Alerts (<a href="https://redirect.github.com/pygithub/pygithub/issues/3307">#3307</a>)</li> <li><a href="https://github.com/PyGithub/PyGithub/commit/95648db4780e977b5bad8c19f669ec3f8c2b1a49"><code>95648db</code></a> Add Python 3.14 to CI and tox (<a href="https://redirect.github.com/pygithub/pygithub/issues/3429">#3429</a>)</li> <li><a href="https://github.com/PyGithub/PyGithub/commit/3716bab10b7a99445ef50d698d6b2d681620ac88"><code>3716bab</code></a> Use <code>GET</code> url or <code>_links.self</code> as object url (<a href="https://redirect.github.com/pygithub/pygithub/issues/3421">#3421</a>)</li> <li>Additional commits viewable in <a href="https://github.com/pygithub/pygithub/compare/v2.8.1...v2.9.1">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
It is hard to debug optimized error if we don't know which rule caused the error
What changes are included in this PR?
Show which rule failed
Are there any user-facing changes?
No