Repository navigation
Minor: update tests in limit_pushdown.rs to insta - #20066
Merged
Merged
Conversation
github-actions
Bot
added
optimizer
alamb
commented
Jan 29, 2026
| ]; | ||
| assert_eq!(initial, expected_initial); | ||
| let initial = format_plan(&global_limit); | ||
| insta::assert_snapshot!( |
Contributor
Author
There was a problem hiding this comment.
The point is to use this alternate format which is easier to update and to diff
avantgardnerio
approved these changes
Jan 29, 2026
alamb
force-pushed
the
alamb/insta_tests
branch
from
January 30, 2026 16:23
9abc7d9 to
6ba9ab7
Compare
Contributor
Author
|
I merged rebased after #20048 was merged |
alamb
marked this pull request as ready for review
January 30, 2026 16:24
adriangb
approved these changes
Jan 30, 2026
Contributor
Author
|
Thank you @avantgardnerio and @adriangb |
de-bgunter
pushed a commit
to de-bgunter/datafusion
that referenced
this pull request
Mar 24, 2026
## Which issue does this PR close? - Follow on to apache#20048 ## Rationale for this change While reviewing apache#20048 and verifying test coverage, it was hard for me to see the test differences (b/c the formatting was not great) ## What changes are included in this PR? Port the tests to use insta rather than `assert_eq` ## Are these changes tested? Yes, only tests ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
While reviewing #20048 and verifying test coverage, it was hard for me to see the test differences (b/c the formatting was not great)
What changes are included in this PR?
Port the tests to use insta rather than
assert_eqAre these changes tested?
Yes, only tests
Are there any user-facing changes?