Repository navigation

Fix struct casts to align fields by name (prevent positional mis-casts) - #19674

Merged

kosiew merged 72 commits into

apache:mainfrom

kosiew:struct-casting-17285

Jan 23, 2026

Merged

Fix struct casts to align fields by name (prevent positional mis-casts)#19674
kosiew merged 72 commits into
apache:mainfrom
kosiew:struct-casting-17285

Commits on Dec 30, 2025
Commits on Jan 7, 2026
- Add #17285 reproducer case
  kosiew
  committed
  e337ef7
Commits on Jan 13, 2026
- Add name-overlap detection and struct casting validation
  kosiew
  committed
  b0ed1ab
- Add null fast paths for struct casting and checks
  kosiew
  committed
  cad6eac
- refactor: Improve struct casting logic and enhance readability
  kosiew
  committed
  9b61e2f
- Fix plan errors from optimizer rule failures
  kosiew
  committed
  b22a742
- fix clippy
  kosiew
  committed
  8682073
- cargo fmt
  kosiew
  committed
  cc926b3
- docs(common): avoid intra-doc link to private function in nested_struct
  kosiew
  committed
  0fe71b3
- docs(common): avoid broken intra-doc link to ParquetWriterOptions behind 'parquet' feature
  kosiew
  committed
  d0f1cc0
Commits on Jan 14, 2026
Commits on Jan 16, 2026
- struct casting: validate missing non-nullable target fields; add tests
  kosiew
  committed
  aa04ded
- fix(tests): streamline source struct initialization in casting tests
  kosiew
  committed
  6558d69
- fix clippy warning
  kosiew
  committed
  bdf5f20
Commits on Jan 17, 2026
- Validate nullability of fields and improve error handling
  kosiew
  committed
  682d28a
- Fix struct casting validation: check nullability for NULL source types and validate at planning time
  kosiew
  committed
  63e80f6
- Make cast_struct_array_by_name an internal function (pub(crate))
  kosiew
  committed
  0d5126c
- Document necessity of null check in cast_struct_column for direct callers
  kosiew
  committed
  81e56fb
- Document field name uniqueness assumptions in fields_have_same_names
  kosiew
  committed
  f304499
- Add debug assertions to validate field name uniqueness in fields_have_same_names
  kosiew
  committed
  5f08346
- Add comprehensive tests for struct cast const-folding behavior
  kosiew
  committed
  c74bddd
- Revert error handling in Optimizer
  kosiew
  committed
  2734da2
- Refactor imports in expr_simplifier.rs
  kosiew
  committed
  b9d79fc
- fix: improve error message for struct casting with mismatched field counts in SQL logic test
  kosiew
  committed
  77a7f94
- fix: clarify comment on null handling for struct column casting
  kosiew
  committed
  914356f
- fix: remove unnecessary null handling checks in struct column casting
  kosiew
  committed
  af8e034
- fix: prevent const-folding of empty struct cast literals
  kosiew
  committed
  20d1c38
- fix clippy
  kosiew
  committed
  e1eff12
- fix: simplify imports and improve test readability
  kosiew
  committed
  ec26c5e
- tests(expr_simplifier): extract helper to create empty StructArray
  kosiew
  committed
  f557de2
- tests: extract make_struct_cast_expr helper for struct-cast tests
  kosiew
  committed
  11e8745
- test: ensure struct cast with different field counts remains unchanged
  kosiew
  committed
  da60ed9
- test: improve struct cast test assertions
  kosiew
  committed
  7652dbb
- test: update assertions for struct cast simplification to use assert_ne
  kosiew
  committed
  ea748d3
- test: add case for struct cast with empty array not being foldable
  kosiew
  committed
  f5642db
- refactor: remove cast_struct_array_by_name wrapper, consolidate on cast_column
  kosiew
  committed
  9f1d56e
- cargo fmt
  kosiew
  committed
  5a4ecb1
Commits on Jan 20, 2026
Commits on Jan 23, 2026
- Merge branch 'main' into struct-casting-17285
  kosiew
  committed
  68819ff