You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Refactor the implementation to simplify it, and also fix which types we coerce.
What changes are included in this PR?
When coercing input types, we ignore the 1st argument (it is only used to calculate if return 2nd or 3rd argument so no need to consider it for coercion). Also simplify the actual implementation.
I was planning on doing the same simplification as in #17982 where nvl2(x, y, z) would get simplified to case when x is not null then y else z end. The rationale is to try to make the various lazy, conditional logic variants (nvl, nvl2, coalesce) all aliases of CaseExpr so that we only have to optimise it once.
I was planning on doing the same simplification as in #17982 where nvl2(x, y, z) would get simplified to case when x is not null then y else z end. The rationale is to try to make the various lazy, conditional logic variants (nvl, nvl2, coalesce) all aliases of CaseExpr so that we only have to optimise it once.
Sounds good, I'll close this PR and close the refactor issue as unplanned
Also fyi @kosiew since I see you self-assigned #17983
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Refactor the implementation to simplify it, and also fix which types we coerce.
What changes are included in this PR?
When coercing input types, we ignore the 1st argument (it is only used to calculate if return 2nd or 3rd argument so no need to consider it for coercion). Also simplify the actual implementation.
Are these changes tested?
Existing tests.
Are there any user-facing changes?
No.