Repository navigation
Simplify Between expression to Eq - #14994
Merged
Merged
Conversation
github-actions
Bot
added
optimizer
This was referenced Mar 4, 2025
alamb
approved these changes
Mar 4, 2025
alamb
left a comment
alamb
left a comment
Contributor
There was a problem hiding this comment.
Thanks @jayzhan211
#14943 seems to be about predicates such as s.foo = 'a' and 'a' = s.foo, so While PR seems like a reasonable improvement, I don't think it closes #14943
There might also be a more general way to implement this related to constraint propagation 🤔
alamb
reviewed
Mar 4, 2025
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
Contributor
There was a problem hiding this comment.
I like the idea of using slt for simplification testing
Contributor
Author
I agree it. |
danila-b
pushed a commit
to danila-b/datafusion
that referenced
this pull request
Mar 8, 2025
* simplify between equal case * cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?