Repository navigation
Conversation
Contributor
Author
|
cc @lewiszlw |
korowa
force-pushed
the
build-side-keys-mem
branch
from
January 21, 2025 18:05
290e54b to
42e430e
Compare
xudong963
self-requested a review
January 22, 2025 10:17
Closed
korowa
force-pushed
the
build-side-keys-mem
branch
from
February 18, 2025 05:10
42e430e to
944e297
Compare
korowa
force-pushed
the
build-side-keys-mem
branch
from
February 18, 2025 05:12
944e297 to
417a921
Compare
This was referenced Feb 24, 2025
4 of 11 tasks
|
Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow-up on #14131
Rationale for this change
Having precalculated build-side join keys in
JoinLeftDatamay be a noticeable overhead in terms of memory (always has been, but previously it's been recreated on each hashtable lookup), so it makes sense to add its memory into build-side data memory reservation.What changes are included in this PR?
concatbeing non-consuming (and, thus, creating a copy of input data), concat operations for build-side join keys and record batches are now preceded by doubling up memory reservation for source data (trying to predict concatenated copy size), and followed by explicit drop of source data and resizing reservation to actual memory size ofconcatresult.Are these changes tested?
Existing test coverage, checking that build-side join keys evaluation not messed up.
Are there any user-facing changes?
No