Repository navigation
chore: Prepare 43.0.0 release - #13254
Merged
Merged
Conversation
github-actions
Bot
added
documentation
findepi
approved these changes
Nov 5, 2024
andygrove
commented
Nov 5, 2024
Comment on lines
-56
to
-60
| if [[ -z "${GH_TOKEN}" ]]; then | ||
| echo "Please set personal github token through GH_TOKEN environment variable" | ||
| exit | ||
| fi | ||
|
|
Member
Author
There was a problem hiding this comment.
This script does not use GitHub
comphead
reviewed
Nov 5, 2024
| | datafusion.execution.parquet.max_statistics_size | 4096 | (writing) Sets max statistics size for any column. If NULL, uses default parquet writer setting | | ||
| | datafusion.execution.parquet.max_row_group_size | 1048576 | (writing) Target maximum number of rows in each row group (defaults to 1M rows). Writing larger row groups requires more memory to write, but can get better compression and be faster to read. | | ||
| | datafusion.execution.parquet.created_by | datafusion version 42.2.0 | (writing) Sets "created by" property | | ||
| | datafusion.execution.parquet.created_by | datafusion version 43.0.0 | (writing) Sets "created by" property | |
Contributor
There was a problem hiding this comment.
I think we can rephrase it to avoid the exact version 🤔
Member
Author
There was a problem hiding this comment.
The docs are generated directly from code:
/// (writing) Sets "created by" property
pub created_by: String, default = concat!("datafusion version ", env!("CARGO_PKG_VERSION")).into()
Member
Author
There was a problem hiding this comment.
It is probably possible to add some special case processing to the macros that generate the docs
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #12470
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?