Skip to content

Single multi groupby v2 - #11777

Closed
jayzhan211 wants to merge 6 commits into
apache:mainfrom
jayzhan211:single-multi-groupby-v2
Closed

jayzhan211 wants to merge 6 commits into
apache:mainfrom
jayzhan211:single-multi-groupby-v2

Conversation

@jayzhan211

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Closes #.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
@github-actions github-actions Bot added core Core DataFusion crate sqllogictest SQL Logic Tests (.slt) labels Aug 2, 2024
// benchmark time: [150.22 ms 154.31 ms 158.06 ms]
// change: [+254.76% +261.92% +270.28%] (p = 0.00 < 0.05)
// Performance has regressed.
// Found 1 outliers among 10 measurements (10.00%) No newline at end of file

@jayzhan211 jayzhan211 Aug 2, 2024 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// this change
// Gnuplot not found, using plotters backend
// Benchmarking benchmark: Warming up for 3.0000 s
// Warning: Unable to complete 10 samples in 5.0s. You may wish to increase target time to 8.2s or enable flat sampling.
// benchmark               time:   [150.22 ms 154.31 ms 158.06 ms]
//                         change: [+254.76% +261.92% +270.28%] (p = 0.00 < 0.05)
//                         Performance has regressed.
// Found 1 outliers among 10 measurements (10.00%)

// main
// Gnuplot not found, using plotters backend
// Benchmarking benchmark: Warming up for 3.0000 s
// Warning: Unable to complete 10 samples in 5.0s. You may wish to increase target time to 29.0s.
// benchmark               time:   [2.0650 s 3.5149 s 5.1064 s]
//                         change: [+1182.7% +2229.6% +3244.4%] (p = 0.00 < 0.05)
//                         Performance has regressed.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got 2.1296 for main

// change: [-6.5657% -5.6393% -4.6452%] (p = 0.00 < 0.05)
// Performance has improved.
// Found 1 outliers among 10 measurements (10.00%)
// 1 (10.00%) high mild No newline at end of file

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

single-multi-groupby-v2

Gnuplot not found, using plotters backend
// benchmark               time:   [41.512 ms 41.931 ms 42.318 ms]
//                         change: [-6.5657% -5.6393% -4.6452%] (p = 0.00 < 0.05)
//                         Performance has improved.
// Found 1 outliers among 10 measurements (10.00%)
//   1 (10.00%) high mild

main

Gnuplot not found, using plotters backend
benchmark               time:   [43.127 ms 43.299 ms 43.636 ms]
                        change: [-99.150% -98.764% -97.880%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 1 outliers among 10 measurements (10.00%)
  1 (10.00%) high severe

@jayzhan211

Copy link
Copy Markdown
Contributor Author

I found removing pre-partition cause huge regression for many queries

@jayzhan211 jayzhan211 closed this Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant