Repository navigation
move Floor, Gcd, Lcm, Pi to datafusion-functions #9861
Description
Is your feature request related to a problem or challenge?
As part of #9285 move the Floor, Gcd, Lcm, Pi functions to the new datafusion-functions crate in the new structure.
Describe the solution you'd like
Functions are migrated to the new crate and use the new patterns as described in #9286 & #9216
Describe alternatives you've considered
No response
Additional context
No response
Activity
tinfoil-knight commentedon Mar 29, 2024
@Omega359 I realised while working on #9868 that some parts (eg: simplifying expressions: search
simpl_log,simpl_power) oflog&powerfunctions are dependent on each other.I think that these functions should be migrated together. Since you're already migrating the
powerfunction, do you want to also pick up thelogfunction in the same PR?Omega359 commentedon Mar 29, 2024
Oh, I just created the tickets .. I wasn't attempting to do all of them @tinfoil-knight :) If you are working on something related feel free to take this ticket too
tinfoil-knight commentedon Mar 30, 2024
@Omega359 Thank you! I just need the
Powerfunction since it's dependent onLog.I've opened a new issue: #9875 for it. Please update this issue to not include the
Powerfunction.[-]move Floor, Gcd, Lcm, Pi, Power to datafusion-functions[/-][+]move Floor, Gcd, Lcm, Pi to datafusion-functions[/+]Omega359 commentedon Apr 5, 2024
take
alamb commentedon Apr 6, 2024
❤️ -- thank you @Omega359