Skip to content

Internal_err! is over used in core code and should be replaced with exec_err! or plan_err! in many places #9164

Closed

Description

@Omega359

Describe the bug

internal_err! is used as a general error macro in many spots in the code where in fact the problem the error is propagating is not caused by an oversight, bug, etc in the code but rather by user error. A good example of this can be seen in PR #9137 comment where it's being used to let the user know they provided a datatype as an argument to a function that it doesn't support. This in fact should be an exec_err! in this example.

To Reproduce

No response

Expected behavior

In most cases where the error is caused by incorrect data types or invalid argument counts exec_err! should be used.

Additional context

No response

Activity

  1. comphead commented on Feb 8, 2024

    @comphead
    Contributor

    Related to #6108

  2. comphead commented on Feb 8, 2024

    @comphead
    Contributor

    looking fwd for the PR :)

  3. Omega359 commented on Feb 20, 2024

    @Omega359
    ContributorAuthor

    take

  4. alamb commented on Feb 28, 2024

    @alamb
    Contributor

    Bug squashed
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions