You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Support GroupsAccumulator accumulator for User Defined Functions #8793
pubtraitAggregateUDFImpl{
...
/// If the aggregate expression has a specialized/// [`GroupsAccumulator`] implementation. If this returns true,/// `[Self::create_groups_accumulator`] will be called.fngroups_accumulator_supported(&self) -> bool{false}/// Return a specialized [`GroupsAccumulator`] that manages state/// for all groups.////// For maximum performance, a [`GroupsAccumulator`] should be/// implemented in addition to [`Accumulator`].fncreate_groups_accumulator(&self) -> Result<Box<dynGroupsAccumulator>>{not_impl_err!("GroupsAccumulator hasn't been implemented for {self:?} yet")}}
GroupsAccumulator is in datafusion-physical-expr package, datafusion-physical-expr package depend datafusion-expr package, so if we use GroupsAccumulator in datafusion-expr package will cause reference loops 😢
GroupsAccumulator is in datafusion-physical-expr package, datafusion-physical-expr package depend datafusion-expr package, so if we use GroupsAccumulator in datafusion-expr package will cause reference loops 😢
Is it possible to move GroupsAccumulator into datafusion_expr (in the same place as Accumulator)?
Activity
guojidan commentedon Jan 9, 2024
I will deal this issue after #8733 finished and merged
guojidan commentedon Jan 12, 2024
GroupsAccumulatoris indatafusion-physical-exprpackage,datafusion-physical-exprpackage dependdatafusion-exprpackage, so if we useGroupsAccumulatorindatafusion-exprpackage will cause reference loops 😢alamb commentedon Jan 12, 2024
Is it possible to move
GroupsAccumulatorintodatafusion_expr(in the same place asAccumulator)?