Make it easier to create ScalarValue from String and &str #8380

Activity

1. alamb

   added

   enhancementNew feature or requestNew feature or request

   good first issueGood for newcomersGood for newcomers

   on Nov 30, 2023
2. QuenKar commented on Dec 1, 2023

   

   QuenKar

   on Dec 1, 2023

   Contributor

   More actions

   Hi, I want to do this issue
3. QuenKar commented on Dec 1, 2023

   

   QuenKar

   on Dec 1, 2023

   Contributor

   More actions

   I met some question in scalar.rs. when adding a test case for it, it can't compiled in vscode. It seems to have something to do with parquet.

   error[E0433]: failed to resolve: use of undeclared crate or module `parquet`
      --> datafusion/common/src/file_options/mod.rs:302:9
       |
   302 |     use parquet::{
       |         ^^^^^^^ use of undeclared crate or module `parquet`
   
   error[E0432]: unresolved import `super::parquet_writer`
      --> datafusion/common/src/file_options/mod.rs:316:17
       |
   316 |     use super::{parquet_writer::ParquetWriterOptions, StatementOptions};
       |                 ^^^^^^^^^^^^^^ could not find `parquet_writer` in `super`
   
   error[E0599]: no variant or associated item named `PARQUET` found for enum `file_type::FileType` in the current scope
      --> datafusion/common/src/file_options/file_type.rs:120:35
       |
   45  | pub enum FileType {
       | ----------------- variant or associated item `PARQUET` not found for this enum
   ...
   120 |             ("parquet", FileType::PARQUET),
       |                                   ^^^^^^^ variant or associated item not found in `FileType`
   
   error[E0599]: no variant or associated item named `PARQUET` found for enum `file_type::FileType` in the current scope
      --> datafusion/common/src/file_options/file_type.rs:121:35
       |
   45  | pub enum FileType {
       | ----------------- variant or associated item `PARQUET` not found for this enum
   ...
   121 |             ("PARQUET", FileType::PARQUET),
       |                                   ^^^^^^^ variant or associated item not found in `FileType`
   
   error[E0425]: cannot find function `parquet_test_data` in this scope
      --> datafusion/common/src/test_util.rs:292:19
       |
   161 | pub fn arrow_test_data() -> String {
       | ---------------------------------- similarly named function `arrow_test_data` defined here
   ...
   292 |         let res = parquet_test_data();
       |                   ^^^^^^^^^^^^^^^^^ help: a function with a similar name exists: `arrow_test_data`
   
   Some errors have detailed explanations: E0425, E0432, E0433, E0599.
   For more information about an error, try `rustc --explain E0425`.
   error: could not compile `datafusion-common` (lib test) due to 5 previous errors
   
4. alamb commented on Dec 1, 2023

   

   alamb

   on Dec 1, 2023

   ContributorAuthor

   More actions

   I met some question in scalar.rs. when adding a test case for it, it can't compiled in vscode. It seems to have something to do with parquet.

   THanks @QuenKar -- I think this is #8250 (also noticed by @jayzhan211 )

   Here is the workaround: #8250 (comment)

   It would be great for someone to fix this

   ❤️React with ❤️1Reacted by Summer1ce
5. alamb

   closed this as completedin #8411on Dec 5, 2023