Skip to content

Port tests in array_expression.rs to sqllogictest #8324

Closed

Description

@jayzhan211

The goal is that there is no rust test in this file anymore.

Part of #6195

Originally posted by @alamb in #8313 (comment)

File an issue to list the pending test to avoid duplicate work

  • make_array
  • array_element
  • array_pop_back
  • array_slice
  • array_append
  • array_prepend
  • array_concat
  • array_position
  • array_to_string
  • cardinality
  • array_length
  • array_dims
  • Port other function to common::utils or just remove it

Activity

  1. changed the title [-]Cleanup `unit_test` in `array_expression.rs`[/-] [+]Port tests in `array_expression.rs` to `sqllogictest`[/+] on Nov 27, 2023
  2. Veeupup commented on Nov 27, 2023

    @Veeupup
    Contributor

    hi @jayzhan211, I can help with make_array array_element array_pop_back

  3. jayzhan211 commented on Nov 27, 2023

    @jayzhan211
    ContributorAuthor

    hi @jayzhan211, I can help with make_array array_element array_pop_back

    Sure! Go ahead.

  4. Veeupup commented on Nov 27, 2023

    @Veeupup
    Contributor

    : )
    I find that almost all test cases have been added to the sqllogictest, so I just remove some duplicate test codes then

  5. jayzhan211 commented on Nov 27, 2023

    @jayzhan211
    ContributorAuthor

    : ) I find that almost all test cases have been added to the sqllogictest, so I just remove some duplicate test codes then

    Close this issue with only delete, cool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions