Add Decimal128 support to Ceil and Floor #7689

Activity

1. kazuyukitanimura

   added

   enhancementNew feature or requestNew feature or request

   on Sep 28, 2023
2. viirya commented on Sep 28, 2023

   

   viirya

   on Sep 28, 2023

   Member

   More actions

   I guess they supports it but a type coercion will happen on decimal input (to float type). Native support is not there though.

   👍React with 👍1Reacted by Alex Huang
3. kazuyukitanimura

   changed the title [-]Add Decimal128 support Ceil and Floor[/-] [+]Add Decimal128 support to Ceil and Floor[/+] on Sep 28, 2023
4. Weijun-H commented on Sep 29, 2023

   

   Weijun-H

   on Sep 29, 2023

   Member

   More actions

   I think @viirya is correct.

   ❯ select ceil(arrow_cast(100000, 'Decimal128(38,1)'));
   +---------------------+
   | ceil(Int64(100000)) |
   +---------------------+
   | 100000.0            |
   +---------------------+
   1 row in set. Query took 0.004 seconds.
   
   ❯ select ceil(arrow_cast(100000.2, 'Decimal128(38,1)'));
   +-------------------------+
   | ceil(Float64(100000.2)) |
   +-------------------------+
   | 100001.0                |
   +-------------------------+
   1 row in set. Query took 0.004 seconds.
5. kumarUjjawal commented on Nov 26, 2025

   

   kumarUjjawal

   on Nov 26, 2025

   Contributor

   More actions

   @kazuyukitanimura Is this still a requirement, I can take a look at it.
6. Jefffrey commented on Nov 26, 2025

   

   Jefffrey

   on Nov 26, 2025

   Contributor

   More actions

   @kazuyukitanimura Is this still a requirement, I can take a look at it.

   Yes this would still be good to have
7. kumarUjjawal commented on Nov 27, 2025

   

   kumarUjjawal

   on Nov 27, 2025

   Contributor

   More actions

   @kazuyukitanimura Is this still a requirement, I can take a look at it.

   Yes this would still be good to have

   Thank you!
8. kumarUjjawal commented on Nov 27, 2025

   

   kumarUjjawal

   on Nov 27, 2025

   Contributor

   More actions

   @Jefffrey I wanted to get your views before jumping on the implementation. I was thinking of replacing the current make_math_unary_udf! wiring for ceil/floor with dedicated UDF structs so we can add a decimal-aware execution path coercing ints/floats but letting Decimal128 pass through and operating directly on the unscaled i128. Does that sound like the right direction?
9. Jefffrey commented on Nov 27, 2025

   

   Jefffrey

   on Nov 27, 2025

   Contributor

   More actions

   That sounds like the approach we'd need to take
10. kumarUjjawal commented on Nov 27, 2025

    

    kumarUjjawal

    on Nov 27, 2025

    Contributor

    More actions

    Great! Thanks
11. github-merge-queue

    added a commit that references this issue on Dec 19, 2025

    Add Decimal support to Ceil and Floor (#18979)

    ...

    This issue will close once commit d493f3d is merged into the 'main' branch.

    d493f3d
12. Jefffrey

    closed this as completedin #18979on Dec 19, 2025