Skip to content

Substrait: Support for more flexible join condition expressions #6544

Closed

Description

@nseekhao

Is your feature request related to a problem or challenge?

If you run a roundtrip test on

SELECT d1.b, d2.c FROM data d1 JOIN data d2 ON CAST(d1.b AS int) = d2.e

you'll got the error Error: Internal("invalid join condition expression").

This is due to the lack of support of expressions not in the form AND(f0(...), ..., fk(...)), where fi() is EQ() in the consumer (ref).

Describe the solution you'd like

Support for more arbitrary join condition expressions.

Describe alternatives you've considered

This effort can be incremental. I just wanted to make sure this gets brought up and tracked.

Additional context

No response

Activity

  1. alamb commented on Jun 11, 2023

    @alamb
    Contributor

    I wonder if #6135 fixes this?

  2. waynexia commented on Nov 13, 2023

    @waynexia
    Member

    The new roundtrip tests cover SQL in this issue (except the CAST part). Closing this ticket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestsubstraitChanges to the substrait crate

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions