Add greatest(T,...) and least(T,...) SQL functions #6531

Activity

1. jimexist

   added

   enhancementNew feature or requestNew feature or request

   on Jun 2, 2023
2. jimexist

   changed the title [-]Add greatest and least SQL functions[/-] [+]Add `greatest(T,...)` and `least(T,...)` SQL functions[/+] on Jun 4, 2023
3. waynexia commented on Nov 14, 2024

   

   waynexia

   on Nov 14, 2024

   Member

   More actions

   I'd like to continue this task if you don't mind. AFAIK there isn't an obvious blocker from the history of #6527 by @jimexist and #12474 by @rluvaton.

   For the topic in #12357 by @alamb, given greatest and least are both supported by PG and in the spec, adding them to the built-in function list makes sense to me.
4. rluvaton commented on Nov 14, 2024

   

   rluvaton

   on Nov 14, 2024

   Last edited by rluvaton

   Member

   More actions

   I reopened my pr, can you please review my code there before I add tests?
5. waynexia commented on Nov 14, 2024

   

   waynexia

   on Nov 14, 2024

   Member

   More actions

   Thank you @rluvaton, from the aspect of progress, I'd personally prefer to continue on #6527. But it's good that you are willing to drive your work. I've skimmed both #6527 and #12474 and both LGTM so far. Feel free to pin me after #12474 is ready for review.
6. alamb commented on Nov 24, 2024

   

   alamb

   on Nov 24, 2024

   Contributor

   More actions

   Upate is that @rluvaton added support for greatest in

   • feat(function): add greatest function #12474

   Perhaps we should file a separate ticket for least 🤔
7. rluvaton commented on Nov 24, 2024

   

   rluvaton

   on Nov 24, 2024

   Member

   More actions

   I'll try to add the least function in the coming week

   ❤️React with ❤️1Reacted by Andrew Lamb
8. alamb

   closed this as completedin #13786on Dec 20, 2024