panic! 'index out of bounds: the len is 0 but the index is 0 with bad sql query

Describe the bug
A malformed query generates a panic rather than an error

To Reproduce

echo "true" > /tmp/foo.csv
cargo run -p datafusion-cli  --no-default-features

Then run select count(distinct) from foo; via sql:

> CREATE EXTERNAL TABLE foo(bar boolean)
STORED AS CSV
LOCATION '/tmp/foo.csv';
0 rows in set. Query took 0 seconds.
> select count(distinct) from foo;
thread 'main' panicked at 'index out of bounds: the len is 0 but the index is 0', datafusion/src/physical_plan/aggregates.rs:116:15
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Expected behavior
I expect an error about "no column specified for count distinct" rather than a panic

@alamb

Hi @alamb Can I try this ?
Should be enough to check if the coerced args in the aggregation returns no result (in physical_plan/aggregates) ?

let arg = coerce(args, input_schema, &signature(fun))?;
if arg.len() == 0 {
    return Err(DataFusionError::Plan(format!(
        "Invalid aggregation '{}'",
        name,
    )));
}

@jgoday

Thanks @jgoday ! Perhaps you can make the error a little more specific -- like "no arguments passed to aggregate {}" or something. But the location looks reasonable

@alamb

Thank you @alamb. I have created a PR #505 for this.
How about this error message?

Aggregate error. Invalid or wrong number of arguments passed to aggregate: {}

I think "Invalid or wrong number of arguments passed to aggregate: {}" is probably sufficient

add bit_and,bit_or,bit_xor,bool_add,bool_or (apache#496)

Bump object_store upper bound from 0.12.2 to 0.12.5

Bump object_store upper bound to 0.12.5 (#408)

Navigation Menu

Repository navigation

panic! 'index out of bounds: the len is 0 but the index is 0 with bad sql query #496

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

panic! 'index out of bounds: the len is 0 but the index is 0 with bad sql query #496

Description

Activity

jgoday commented on Jun 3, 2021

alamb commented on Jun 3, 2021

jgoday commented on Jun 4, 2021

alamb commented on Jun 4, 2021

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions