Repository navigation
array_remove_* returns wrong response for NULLs #21011
Description
Describe the bug
originated from apache/datafusion-comet#3173
> SELECT array_remove_all(make_array(1, null, 2, null, 3), null);
+-------------------------------------------------------------------------+
| array_remove_all(make_array(Int64(1),NULL,Int64(2),NULL,Int64(3)),NULL) |
+-------------------------------------------------------------------------+
| [1, 2, 3] |
+-------------------------------------------------------------------------+
1 row(s) fetched.
Elapsed 0.026 seconds.
> SELECT array_remove(make_array(1, null, 2, null, 3), null);
+---------------------------------------------------------------------+
| array_remove(make_array(Int64(1),NULL,Int64(2),NULL,Int64(3)),NULL) |
+---------------------------------------------------------------------+
| [1, 2, NULL, 3] |
+---------------------------------------------------------------------+
However Trino or Spark in this case return just NULL
To Reproduce
No response
Expected behavior
No response
Additional context
No response
Activity
buraksenn commentedon Mar 17, 2026
take
buraksenn commentedon Mar 17, 2026
Expectation here is to return same responses as Trino and Spark right @comphead? if that is the case I can open a PR for this early tomorrow
comphead commentedon Mar 17, 2026
Thanks @buraksenn I think I already have a PR ready, I'd like to get it faster to #19692
Appreciate if you can review though
buraksenn commentedon Mar 17, 2026
I understand, just checked the PR. As per the implementation, appending null if the element is null should work. Nice quick work @comphead thanks for the heads up
bug: fix `array_remove_*` with NULLS (#21013)
bug: fix `array_remove_*` with NULLS (apache#21013)
[branch-53]: fix `array_remove_*` with NULLS (#21013) (#21016)
bug: fix `array_remove_*` with NULLS (apache#21013)
filter null value during aggregation instead now that apache/datafusi…
ci: add swap during build, use tpchgen-cli (#1443)