Repository navigation
Optimize planning speed / stop cloning Strings / Fields so much #18413
Description
Is your feature request related to a problem or challenge?
While I was working on #18337 I saw a lot of
string copying happening when calculating qualified names and types and fields.
For example, in Expr::to_field there are clones all over the place:
datafusion/datafusion/expr/src/expr_schema.rs
Line 440 in e65dafe
There are also several places where the field names are copied at least twice
Describe the solution you'd like
Stop copying so much
Describe alternatives you've considered
No response
Additional context
No response
Activity
[-]Optimize planning / stop cloning Strings / Fields so much[/-][+]Optimize planning speed / stop cloning Strings / Fields so much[/+]CI: add `clippy::needless_pass_by_value` rule (#18468)
CI: add `clippy::needless_pass_by_value` rule (apache#18468)
Optimize planning / stop cloning Strings / Fields so much (2-3% faste…