Implement tree explain for ValuesExec #15093

Activity

1. Shreyaskr1409 commented on Mar 8, 2025

   

   Shreyaskr1409

   on Mar 8, 2025

   ContributorAuthor

   More actions

   take
2. github-actions

   assigned

   Shreyaskr1409

   on Mar 8, 2025
3. Shreyaskr1409 commented on Mar 8, 2025

   

   Shreyaskr1409

   on Mar 8, 2025

   ContributorAuthor

   More actions

   @irenjj , as per #14032 ValuesExec is deprecated. I tried running some simple queries which I thought would work like:

   explain VALUES (1);

   when I tried running it, I got the following results:

   +   logical_plan Values: (Int64(1))
   +   physical_plan
   +   01)┌───────────────────────────┐
   +   02)│       DataSourceExec      │
   +   03)│    --------------------   │
   +   04)│         bytes: 128        │
   +   05)│       format: memory      │
   +   06)│          rows: 1          │
   +   07)└───────────────────────────┘
   

   Could this be because of the deprecation? Is there something which I could do to figure out why this isn't working out?
4. irenjj commented on Mar 8, 2025

   

   irenjj

   on Mar 8, 2025

   Contributor

   More actions

   #14032

   Hi, @Shreyaskr1409 , maybe we don't need to implement the explain format since it's deprecated. cc @jonathanc-n .
   I've noticed you've picked other tasks, maybe we can implement others first.❤️
5. Shreyaskr1409 commented on Mar 8, 2025

   

   Shreyaskr1409

   on Mar 8, 2025

   Last edited by Shreyaskr1409

   ContributorAuthor

   More actions

   @irenjj Yes, now I am working on the other JsonSink task after this. Actually I am new to this repository so I though it would have been easier to perform the simpler task as you already made some PRs which I did follow but this became the harder one to understand as I just found this was deprecated.

   Maybe we should remove ValuesExec part from #14914 as it is no longer needed. Anyways, thank you!
6. Shreyaskr1409 commented on Mar 8, 2025

   

   Shreyaskr1409

   on Mar 8, 2025

   Last edited by Shreyaskr1409

   ContributorAuthor

   More actions

   please feel free to close this issue if there is no other input. Edit: This comment automatically closed this issue, I did not know there was automation set up.
7. Shreyaskr1409

   closed this as completedon Mar 8, 2025
8. irenjj commented on Mar 8, 2025

   

   irenjj

   on Mar 8, 2025

   Contributor

   More actions

   @irenjj Yes, now I am working on the other JsonSink task after this. Actually I am new to this repository so I though it would have been easier to perform the simpler task as you already made some PRs which I did follow but this became the harder one to understand as I just found this was deprecated.

   Maybe we should remove ValuesExec part from #14914 as it is no longer needed. Anyways, thank you!

   Thank you for your work! Feel free to reach out to me if you have any questions.❤️