Skip to content

Change in 46: count_all() expr_fn function now displayed as count(1) rather than count(*) #14894

Closed

Description

@alamb

This is fallout from #14824

There is a small change in behavior now from DataFusion 45 and DataFusion 46

There were several tests changed (see link below)

In order to preserve behavior from the old version, perhaps we should change count_all() to return count(1) as "count(*)" so it would be consistent with older versions?

Originally posted by @alamb in #14824 (comment)

Activity

  1. added theissue type on Feb 26, 2025
  2. alamb commented on Feb 26, 2025

    @alamb
    ContributorAuthor

    Since there is a proposed fix in #14824 (comment)

    Maybe someone can apply the fix and update the tests ?

  3. added
    bugSomething isn't working
    regressionSomething that used to work no longer does
    on Feb 26, 2025
  4. removed theissue type on Feb 26, 2025
  5. jayzhan211 commented on Feb 27, 2025

    @jayzhan211
    Contributor

    I think this is quite different from #14895

  6. self-assigned this
    on Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingregressionSomething that used to work no longer does

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions