Repository navigation
Code clean for new datafusion-cli streaming printing logic #14886
Description
Activity
- changed the title
[-]Code clean for new datafusion-cli streaming logic[/-][+]Code clean for new datafusion-cli streaming printing logic[/+]on Feb 26, 2025 I think this is a nice first isuse for someone who wants to make the code nicer and it is currently tested and could be handled without deep datafusion knowledge
It does require some non trivial rust / refactoring though so it probably isn't a great one for someone new to rust
Reacted by Qi ZhuReacted by Qi ZhuHi @zhuqi-lucas , I would like to work on this issue.
take
Sure @shruti2522 , thanks!
Reacted by Shruti SharmaThanks @shruti2522 -- can't wait to see what you come up with ❤
Reacted by Shruti SharmaHi @zhuqi-lucas , I would like to work on this issue
I think the current status is that the code for this feature was somewhat complicated and in fact caused a regression before the last release so we reverted it.
@zhuqi-lucas has made a new PR with some more tests, but the code is still somewhat complex and thus hard to review. Perhaps you can help review / improve that pR?
Reacted by Qi Zhutake
@alamb, checking if my understanding of the issue is accurate since there are a few threads here. This is my first issue on the project, so I want to clarify prior to proceeding.
The current code for printing tables in the CLI has a method with too many parameters, which makes debugging difficult, and the explain plans aren't displaying correctly.
To solve this, one way is to create a struct that holds all the parameters instead of passing them individually. Thus, we are cleaning up some code and moving it to methods and creating the state struct.Closed -- thanks @nssalian and @zhuqi-lucas
Is your feature request related to a problem or challenge?
This is a follow-up for:
#14877 (comment)
And we can do some code clean work including:
Describe the solution you'd like
No response
Describe alternatives you've considered
No response
Additional context
No response