Skip to content

Datafusion-cli: when the max rows setting inf, we are missing the unlimited case for bounded streaming. #14814

Description

@zhuqi-lucas

Describe the bug

#14766

After above improvement, we improved the datafusion-cli memory usage and memory reservation, but we forgot one case:

When the max rows setting inf, we are missing the unlimited case for bounded streaming.

To Reproduce

/usr/bin/time -l cargo run --release --   -m 20G --mem-pool-type fair  --maxrows inf -f '/Users/zhuqi/arrow-datafusion/benchmarks/data/external_sort.sql'

The above will show nothing, because we are not adding unlimited case for bounded streaming to current buffer.

Expected behavior

We should support unlimited case, we can get all the result print.

Additional context

No response

Activity

  1. changed the title [-]Datafusion-cli, when the max rows setting inf, we are missing the unlimited case for bounded streaming.[/-] [+]Datafusion-cli: when the max rows setting inf, we are missing the unlimited case for bounded streaming.[/+] on Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions