Skip to content

Validate all remaining failures in sqlite tests #13972

Description

@Omega359

Is your feature request related to a problem or challenge?

Now that the sqlite test have been merged (#13936) the remaining failures in the tests must be looked at manually and either:

  • marked as skipif Datafusion with an explanation (sql is nonstandard/invalid/etc)
  • marked as skipIf Datafusion with a link to an existing issue
  • a new ticket created and the corresponding failures marked with a link to the new issue and a skipif Datafusion line added.

For examples of how to add this to the .slt files in datafusion-testing search for skipif Datafusion in those files.

Fixes/changes will need to have a PR created in the datafusion-testing repo and merged in before it will be visible to CI/etc in datafusion.

I do not have an exact count of the number of failures as the sqllogictest is fail-fast however I expect it to be in the low hundreds with many of those being variations on existing issues.

Describe the solution you'd like

At the end of this process running the sqlite test suite (INCLUDE_SQLITE=true cargo test --profile release-nonlto --test sqllogictests) should result in no failures.

Describe alternatives you've considered

No response

Additional context

No response

Activity

  1. Omega359 commented on Jan 1, 2025

    @Omega359
    ContributorAuthor

    Epic this ticket is under: #13811

  2. Omega359 commented on Jan 16, 2025

    @Omega359
    ContributorAuthor

    The tests now run to completion in CI. That means this ticket can be closed however there still are outstanding issues with the tests that should be resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions