Skip to content

substrait_integration integration tests are failing #13854

Closed
#13857
Closed
substrait_integration integration tests are failing#13854
#13857
Labels
bugSomething isn't workinggood first issueGood for newcomers

Description

@alamb
alamb
opened on Dec 19, 2024

Describe the bug

substrait_integration integration tests are failing

To Reproduce

on main at 9f530dd

cargo test -p datafusion-substrait

Fails like this:

failures:

---- cases::roundtrip_logical_plan::roundtrip_literal_list stdout ----
Error: Internal("Expected a simplified result, but none was found")

---- cases::roundtrip_logical_plan::roundtrip_values stdout ----
Error: Internal("Expected a simplified result, but none was found")


failures:
    cases::roundtrip_logical_plan::roundtrip_literal_list
    cases::roundtrip_logical_plan::roundtrip_values

test result: FAILED. 133 passed; 2 failed; 7 ignored; 0 measured; 0 filtered out; finished in 0.15s

error: test failed, to rerun pass `-p datafusion-substrait --test substrait_integration`

Expected behavior

I expect

  1. the tests to pass
  2. These tests are run as part of CI

Additional context

No response

Activity

  1. alamb
    added
    bugSomething isn't working
    good first issueGood for newcomers
    on Dec 19, 2024

  2. alamb commented on Dec 19, 2024

    @alamb
    alamb
    on Dec 19, 2024
    ContributorAuthor

    It would be sweet if someone could git bisect and figure out when these started failing

  3. Blizzara commented on Dec 20, 2024

    @Blizzara
    Blizzara
    on Dec 20, 2024
    Contributor

    Hmm, the two tests are failing for me locally as well. However they are run in CI, and there they pass. Looking at the commit you linked for example (but current head of main has the same), https://github.com/apache/datafusion/actions/runs/12413804942/job/34656476010:

         Running tests/substrait_integration.rs (target/debug/deps/substrait_integration-3d7ea520729be616)

running 142 tests
test cases::consumer_integration::tests::tpch_test_03 ... ok
..
test cases::roundtrip_logical_plan::roundtrip_literal_list ... ok
..
test cases::roundtrip_logical_plan::roundtrip_values ... ok
..

test result: ok. 135 passed; 0 failed; 7 ignored; 0 measured; 0 filtered out; finished in 1.51s

    vs locally I get same as you:

    failures:
    cases::roundtrip_logical_plan::roundtrip_literal_list
    cases::roundtrip_logical_plan::roundtrip_values

test result: FAILED. 133 passed; 2 failed; 7 ignored; 0 measured; 0 filtered out; finished in 0.27s
  4. Blizzara
    added a commit that references this issue on Dec 20, 2024

    enable DF's nested_expressions feature by in datafusion-substrait tes…

    3e6823d

  5. Blizzara commented on Dec 20, 2024

    @Blizzara
    Blizzara
    on Dec 20, 2024
    Contributor

    bisect lead to 11d49b4. Specifically, this change: https://github.com/apache/datafusion/pull/13594/files#diff-d195b6dfaaed44b9828e145dc50c075c77b7faf8f44783ca5e6eda2c617af928L39

  6. alamb
    closed this as completedin #13857on Dec 20, 2024
  7. alamb
    closed this as completedin d7aeb1aon Dec 20, 2024
  8. alamb
    added a commit that references this issue on Dec 20, 2024

    enable DF's nested_expressions feature by in datafusion-substrait tes…

    d7aeb1a
  9. jayzhan211
    added 2 commits that reference this issue on Jan 20, 2025

    Update logical-types to main (#14202)

    d094edc

    Update Logical Types Branch (#14241)

    25f02a7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinggood first issueGood for newcomers

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions