Skip to content

Improve performance of median function #13550

Description

@alamb

Is your feature request related to a problem or challenge?

The corr function is used in the h20 benchmark and is quite slow.

https://github.com/apache/datafusion/blob/main/datafusion/functions-aggregate/src/median.rs

It would be great to make it faster so our performance in the H2o benchmark improves

Describe the solution you'd like

See details on #13548

  1. Add a benchmark for median function
  2. Improve performance of median function (likely by implementing GroupsAccumulator)

Describe alternatives you've considered

No response

Additional context

Used here in @MrPower's benchmark:

https://github.com/MrPowers/mrpowers-benchmarks/blob/0b586a0657d7f6cfd55d89508e15b95e79bd4010/benchmarks/datafusion_h2o_groupby_queries.py#L25

Activity

  1. Rachelint commented on Nov 24, 2024

    @Rachelint
    Contributor

    take

  2. Rachelint commented on Nov 28, 2024

    @Rachelint
    Contributor

    A bit busy this month, back and start to push it forward today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions