Skip to content

Support ORDER BY in Substrait aggregate functions #13113

Description

@bvolpato

Is your feature request related to a problem or challenge?

There is proper decoding of Substrait into aggregate functions in DataFusion, but it silently drops any sort fields from the original plan.

Looking at the plan: https://github.com/apache/datafusion/blob/main/datafusion/substrait/src/logical_plan/consumer.rs#L716-L726, it was left as a TODO when implemented:

// TODO: Add parsing of order_by also

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Additional context

I plan to take a stab at this.

Activity

  1. bvolpato commented on Oct 25, 2024

    @bvolpato
    ContributorAuthor

    take

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions