Skip to content

Document DataFusion Threading / tokio runtimes (how to separate IO and CPU bound work) #12393

Closed

Description

@tustvold

Is your feature request related to a problem or challenge?

DataFusion performs CPU bound work within async closures. This causes issues if running IO on the same async runtime, as the cooperative nature of such schedulers allows the CPU bound work to starve servicing of IO. This leads to errors such as apache/arrow-rs-object-store#272.

Describe the solution you'd like

I think at the very least this needs to be better documented, I couldn't find any mention of this in the DataFusion documentation following a cursory search.

I also think more holistic approach would be valuable to this, as it stands the use of async within DataFusion acts as a massive footgun that encourages users to intermix IO and CPU work in a way that is at best inefficient, but this can be tracked as a separate follow on task.

Describe alternatives you've considered

No response

Additional context

No response

Activity

  1. alamb commented on Sep 9, 2024

    @alamb
    Contributor

    I recommend two things:

    1. Write a blog with background and explanation of why using two threadpools is important with DataFusion and examples of how to do it
    2. Add additional documentation (ideally linking to the blog) with a summary and linking to the blog with content.
  2. changed the title [-]Document DataFusion Threading[/-] [+]Document DataFusion Threading (and how to separate IO and CPU bound work)[/+] on Sep 9, 2024
  3. ozankabak commented on Oct 7, 2024

    @ozankabak
    Contributor

    I think it'd be great to have a good documentation on this.

  4. alamb commented on Oct 25, 2024

    @alamb
    Contributor

    I think it'd be great to have a good documentation on this.

    100% agree -- @itsjunetime and @tustvold are working on a bit of it in apache/arrow-rs#6612. I'll try and help with the documentation as well

  5. changed the title [-]Document DataFusion Threading (and how to separate IO and CPU bound work)[/-] [+]Document DataFusion Threading / tokio runtimes (how to separate IO and CPU bound work)[/+] on Nov 11, 2024
  6. self-assigned this
    on Nov 14, 2024
  7. alamb commented on Nov 16, 2024

    @alamb
    Contributor

    Documentation

    I hope to work on the example a bit more shortly

  8. adriangb commented on Dec 3, 2024

    @adriangb
    Contributor

    I was thinking, beyond examples, could we include a basic implementation in DataFusion? I'm not saying it's wired up by default, but put it behind a feature flag and make it provisional but ship it with the source code? Maybe that + docs on how to use it is enough for a lot of use cases?

    I think we have a working version of this in 2 files and not that many LOC. We'd be happy to donate it.

  9. alamb commented on Dec 3, 2024

    @alamb
    Contributor

    I was thinking, beyond examples, could we include a basic implementation in DataFusion? I'm not saying it's wired up by default, but put it behind a feature flag and make it provisional but ship it with the source code? Maybe that + docs on how to use it is enough for a lot of use cases?

    Yes I agree this would be ideal. Thank you @adriangb

    I think we have a working version of this in 2 files and not that many LOC. We'd be happy to donate it.

    That would be awesome -- thank you! I can potentially adapt my example to use what you have

    Any chance you can make a PR?

  10. adriangb commented on Dec 3, 2024

    @adriangb
    Contributor
  11. alamb commented on Dec 8, 2024

    @alamb
    Contributor

    Update here:

  12. alamb commented on Jun 20, 2025

    @alamb
    Contributor

    I am still looking for a committer to help review the next round of this example (which uses the object_store APIs)

  13. alamb commented on Jun 23, 2025

    @alamb
    Contributor

    😅 "finally"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions