Skip to content

Reduce test duplication in tests for data page stattistics #11000

Closed

Description

@alamb

Follow on to #10982

@tshauck noted there is non trivial repetition in some tests

@tmi says:

@tshauck this is one of the things that were bugging me a bit, the other one being https://github.com/apache/datafusion/pull/10982/files#diff-7110f4709c105a18ef74a212396444d62052179a735d148fb62470a8b157fb40R749-R763 -- both are very repetitive

however, I didn't want to get overeager, only to realize later than the abstractions chosen was not the right one. Perhaps the best way forward would be to address #10952 first (which may also have its own "float16"-like tricky case), and then getting the correct macros for testing, index handling, etc. Speaking of that, would you like to take that one? I'd be happy to review then

Originally posted by @tmi in #10982 (comment)

Activity

  1. alamb commented on Jul 8, 2024

    @alamb
    ContributorAuthor

    I propose we consolidate / review the tests when we move this code upstream: apache/arrow-rs#4328

  2. self-assigned this
    on Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions