Repository navigation
Move Value::Interval to Expr::Interval - #609
Merged
Merged
Conversation
Value::Interval to Expr::Interval
alamb
approved these changes
Sep 27, 2022
Contributor
There was a problem hiding this comment.
This makes sense to me @ding-young -- thank you for the contribution
I think @togami2864 added Expr support for Interval in #517 whereas it previously was only a literal
Pull Request Test Coverage Report for Build 3099121905
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current ast
Intervalis defined as a variant of enumValue, which means a literal value. However, considering that the fieldvalueof Interval holds wrapped Expr,Valuebecomes somewhat requires endless evaluation... not "literal". Personally, it would be nice to change Value::Interval to Expr::Interval.