Repository navigation
make parse_expr_with_alias public - #1444
Merged
Merged
Conversation
alamb
reviewed
Sep 26, 2024
alamb
left a comment
Contributor
There was a problem hiding this comment.
Thanks @Eason0729 -- makes sense to me
| } | ||
|
|
||
| fn parse_expr_with_alias(&mut self) -> Result<ExprWithAlias, ParserError> { | ||
| pub fn parse_expr_with_alias(&mut self) -> Result<ExprWithAlias, ParserError> { |
Contributor
There was a problem hiding this comment.
Could you please also add some documentation to this function (perhaps with an example or two) now that it will become part of the public API?
Contributor
Author
There was a problem hiding this comment.
Sorry for missing that piece of document, I have updated it.
Pull Request Test Coverage Report for Build 11091680075Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
iffyio
reviewed
Sep 29, 2024
Co-authored-by: Ifeanyi Ubah <ify1992@yahoo.com>
alamb
approved these changes
Sep 29, 2024
alamb
left a comment
Contributor
There was a problem hiding this comment.
I took the liberty of applying @iffyio 's suggestion and I think the docs are now looking very nice
Thank you @Eason0729 and @iffyio
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Some very small change, as the title said.
close #1439